Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Order.Height #2186

Closed
wants to merge 11 commits into from
Closed

[Merged by Bors] - feat: port Order.Height #2186

wants to merge 11 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Feb 10, 2023

Open in Gitpod

@urkud urkud force-pushed the port/Order.Height branch 2 times, most recently from 02a9678 to 4cba79a Compare February 11, 2023 02:59
@semorrison semorrison added the awaiting-author A reviewer has asked the author a question or requested changes label Mar 29, 2023
@int-y1 int-y1 added mathlib-port This is a port of a theory file from mathlib. help-wanted The author needs attention to resolve issues and removed awaiting-author A reviewer has asked the author a question or requested changes labels Apr 4, 2023
@int-y1
Copy link
Collaborator

int-y1 commented Apr 4, 2023 •
edited by Parcly-Taxel
Loading

todo

  • chainHeight_union_le has errors at of_mem_filter and Multiset.filter_add_filter
  • chainHeight_union_eq has a rewrite failure at chainHeight_add_le_chainHeight_add
  • wellFoundedGT_of_chainHeight_ne_top has an invalid field notation at a.prop

@Ruben-VandeVelde Ruben-VandeVelde added awaiting-review and removed help-wanted The author needs attention to resolve issues labels Apr 7, 2023
@semorrison
Copy link
Contributor

I'm happy to merge as is now. Feel free to consider this delegated to anyone. :-)

@semorrison
Copy link
Contributor

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Apr 10, 2023
bors bot pushed a commit that referenced this pull request Apr 10, 2023
@Ruben-VandeVelde @urkud
@int-y1 @semorrison
feat: port Order.Height (#2186)
74e4a55 
Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
Co-authored-by: int-y1 <jason_yuen2007@hotmail.com>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Apr 10, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Order.Height [Merged by Bors] - feat: port Order.Height Apr 10, 2023
@bors bors bot closed this Apr 10, 2023
@bors bors bot deleted the port/Order.Height branch April 10, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@urkud @int-y1 @semorrison @Ruben-VandeVelde