Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: do not lint line length of lines that start with ! #2190

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - chore: do not lint line length of lines that start with ! #2190

wants to merge 3 commits into from

Conversation

jcommelin
Copy link
Member

Open in Gitpod

@jcommelin jcommelin added awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. labels Feb 10, 2023
eric-wieser
eric-wieser reviewed Feb 10, 2023
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the wrapped lines at the same time?

jcommelin and others added 2 commits February 10, 2023 11:28
@jcommelin @eric-wieser
Update scripts/lint-style.py
ea31812 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@jcommelin
fix two files
3ca70f8
eric-wieser
eric-wieser approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Thanks!

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Feb 10, 2023
bors bot pushed a commit that referenced this pull request Feb 10, 2023
@jcommelin
chore: do not lint line length of lines that start with ! (#2190)
1f93487
@bors
Copy link

bors bot commented Feb 10, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore: do not lint line length of lines that start with ! [Merged by Bors] - chore: do not lint line length of lines that start with ! Feb 10, 2023
@bors bors bot closed this Feb 10, 2023
@bors bors bot deleted the dont-lint-bang-lines branch February 10, 2023 12:24
mo271 pushed a commit that referenced this pull request Feb 10, 2023
@jcommelin @mo271
chore: do not lint line length of lines that start with ! (#2190)
2f6b3af
urkud pushed a commit that referenced this pull request Feb 11, 2023
@jcommelin @urkud
chore: do not lint line length of lines that start with ! (#2190)
4b6c6ce
mo271 pushed a commit that referenced this pull request Feb 18, 2023
@jcommelin @mo271
chore: do not lint line length of lines that start with ! (#2190)
1b46464
alexjbest added a commit that referenced this pull request Aug 14, 2023
@alexjbest
don't except ! lines anymore reverts #2190
4cc14e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcommelin @eric-wieser @semorrison