Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: forward-port leanprover-community/mathlib#18421 #2191

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - chore: forward-port leanprover-community/mathlib#18421 #2191

wants to merge 4 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Feb 10, 2023 •
edited

@eric-wieser eric-wieser added mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged awaiting-CI labels Feb 10, 2023
@eric-wieser eric-wieser mentioned this pull request Feb 10, 2023
Closed
bors bot pushed a commit to leanprover-community/mathlib that referenced this pull request Feb 10, 2023
@eric-wieser
chore(algebra/group_with_zero/units/lemmas): div_div_cancel_left' (#…
dc6c365 
…18421)

This is the `group_with_zero` version of `div_div_cancel_left`.

Forward-ported in leanprover-community/mathlib4#2191
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR and removed awaiting-CI labels Feb 27, 2023
Vierkantor
Vierkantor approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 28, 2023
bors bot pushed a commit that referenced this pull request Feb 28, 2023
@eric-wieser
chore: forward-port leanprover-community/mathlib#18421 (#2191)
0422d4a
@bors
Copy link

bors bot commented Feb 28, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore: forward-port leanprover-community/mathlib#18421 [Merged by Bors] - chore: forward-port leanprover-community/mathlib#18421 Feb 28, 2023
@bors bors bot closed this Feb 28, 2023
@bors bors bot deleted the forward-port-18421 branch February 28, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees
No one assigned
Labels
mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors.
Projects
No open projects
Forward ports of mathlib3
Status: SHA added
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eric-wieser @Vierkantor @semorrison