Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Dfinsupp.Lex #2199

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - feat: port Data.Dfinsupp.Lex #2199

wants to merge 8 commits into from

Conversation

int-y1
Copy link
Collaborator

@int-y1 int-y1 commented Feb 11, 2023

Open in Gitpod

@int-y1
feat: port Data.Dfinsupp.Lex
589e11e
@int-y1
Initial file copy from mathport
fa1ea98
@int-y1
automated fixes
6ba4afd 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@int-y1 int-y1 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Feb 11, 2023
@int-y1
Copy link
Collaborator Author

int-y1 commented Feb 11, 2023

Remaining tasks:

  • Fix deprecated Dfinsupp.coeFn_injective in Lex.partialOrder
  • Clean up mathport comments for Lex.decidableLe Lex.decidableLt

@int-y1 int-y1 added the help-wanted The author needs attention to resolve issues label Feb 11, 2023
@LukasMias LukasMias added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues WIP Work in progress labels Feb 12, 2023
dupuisf
dupuisf reviewed Feb 12, 2023
View reviewed changes
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 12, 2023
bors bot pushed a commit that referenced this pull request Feb 12, 2023
@int-y1 @LukasMias
feat: port Data.Dfinsupp.Lex (#2199)
7c6b762 
Co-authored-by: Lukas Miaskiwskyi <lukas.mias@gmail.com>
@bors
Copy link

bors bot commented Feb 12, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Dfinsupp.Lex [Merged by Bors] - feat: port Data.Dfinsupp.Lex Feb 12, 2023
@bors bors bot closed this Feb 12, 2023
@bors bors bot deleted the port/Data.Dfinsupp.Lex branch February 12, 2023 23:54
mo271 pushed a commit that referenced this pull request Feb 18, 2023
@int-y1 @LukasMias @mo271
feat: port Data.Dfinsupp.Lex (#2199)
797e952 
Co-authored-by: Lukas Miaskiwskyi <lukas.mias@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dupuisf dupuisf dupuisf left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@int-y1 @dupuisf @semorrison @LukasMias