Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Algebra.Order.Nonneg.Field #2200

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat: port Algebra.Order.Nonneg.Field #2200

wants to merge 5 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Feb 11, 2023 •
edited

Open in Gitpod

@urkud urkud force-pushed the port/Algebra.Order.Nonneg.Field branch 2 times, most recently from 1892024 to 8813c4f Compare February 11, 2023 06:14
@urkud urkud added the mathlib-port This is a port of a theory file from mathlib. label Feb 11, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 11, 2023
@urkud urkud force-pushed the port/Algebra.Order.Nonneg.Field branch from 8deba64 to ec6ad1e Compare February 11, 2023 19:53
@urkud urkud added awaiting-review The author would like community review of the PR and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Feb 11, 2023
@urkud
feat: port Algebra.Order.Nonneg.Field
2b5ecf7
@urkud
Initial file copy from mathport
91c9e29
@urkud
automated fixes
a4836f6 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@urkud
Fix compile
842b296
@urkud
auto: naming
8bcbdaa
@urkud urkud force-pushed the port/Algebra.Order.Nonneg.Field branch from ec6ad1e to 8bcbdaa Compare February 11, 2023 19:57
jcommelin
jcommelin approved these changes Feb 11, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 11, 2023
bors bot pushed a commit that referenced this pull request Feb 11, 2023
@urkud
feat: port Algebra.Order.Nonneg.Field (#2200)
caa2745
@bors
Copy link

bors bot commented Feb 11, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Algebra.Order.Nonneg.Field [Merged by Bors] - feat: port Algebra.Order.Nonneg.Field Feb 11, 2023
@bors bors bot closed this Feb 11, 2023
@bors bors bot deleted the port/Algebra.Order.Nonneg.Field branch February 11, 2023 20:51
mo271 pushed a commit that referenced this pull request Feb 12, 2023
@urkud @mo271
feat: port Algebra.Order.Nonneg.Field (#2200)
f16343d
mo271 pushed a commit that referenced this pull request Feb 18, 2023
@urkud @mo271
feat: port Algebra.Order.Nonneg.Field (#2200)
144282f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @jcommelin @semorrison