Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Nat.Count #2209

Closed
wants to merge 35 commits into from
Closed

[Merged by Bors] - feat: port Data.Nat.Count #2209

wants to merge 35 commits into from

Conversation

xroblot
Copy link
Collaborator

@xroblot xroblot commented Feb 11, 2023 •
edited by github-actions bot

thorimur and others added 26 commits February 7, 2023 04:56
@thorimur
start: create files
10e70e6
@thorimur
chore: update Mathlib.lean
f9869d8
@thorimur
test: port mathlib3 tests
8d2502e
@thorimur
feat: add getFVarId(s)At to Tactic.Core
7af8d0f 
* handles case where we want goal.withContext instead of withMainContext
@thorimur
feat: wlog tactic
8c4c561
@thorimur
test: update tests
990d5e3
@thorimur @digama0
chore: update syntax to match mathport
bfa50ff 
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
@thorimur
test: fix this
c633746
@mcdoll
Update Mathlib/Tactic/WLOG.lean
9566c55
@mcdoll
added a test
52ae9e1
@thorimur
feat: broaden capabilities of getFVarIdsAt
3b4af71
@thorimur
refactor: create definition wlog for goal.wlog
523a4cd 
* keep track of fvarid output in keeping with `intro`/`byCases`/etc.
@thorimur
test: expand tests a little
d933533
@thorimur
chore: minor cleanups
d793224
@thorimur
fix: getFVarIdsAt (overzealous return)
04f0c4b
@thorimur
chore: minor rename
beee187
@thorimur
chore: remove stray set_option from test
77ccd77
@thorimur
feat: account for _ in binderIdent
bf75e67
@thorimur
test: test _ in binderIdent
c824a93
@thorimur
docs: minor fixes
c05d0b4
@thorimur
fix: broaden to impl. details in getFVarIdsAt
acc8562 
* make default
@thorimur
refactor: filterOutImplementationDetails in Core
caebdee
@thorimur
refactor: pull plumbing out of revert & assert
0df245a
@xroblot
feat: port Data.Nat.Count
296eb96
@xroblot
Initial file copy from mathport
5111be7
@xroblot
automated fixes
dd4b867 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@xroblot xroblot added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Feb 11, 2023
@semorrison semorrison added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Feb 11, 2023
@casavaca casavaca mentioned this pull request Feb 12, 2023
Closed
1 task
@semorrison semorrison removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Feb 13, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 13, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 13, 2023
@xroblot xroblot added awaiting-review The author would like community review of the PR WIP Work in progress and removed WIP Work in progress awaiting-review The author would like community review of the PR labels Feb 13, 2023
@xroblot xroblot added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Feb 14, 2023
jcommelin
jcommelin approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 14, 2023
bors bot pushed a commit that referenced this pull request Feb 14, 2023
@thorimur @mcdoll @xroblot
feat: port Data.Nat.Count (#2209)
cc5c152 
Co-authored-by: Moritz Doll <moritz.doll@googlemail.com>
Co-authored-by: Xavier-François Roblot <46200072+xroblot@users.noreply.github.com>
@bors
Copy link

bors bot commented Feb 14, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Nat.Count [Merged by Bors] - feat: port Data.Nat.Count Feb 14, 2023
@bors bors bot closed this Feb 14, 2023
@bors bors bot deleted the port/Data.Nat.Count branch February 14, 2023 08:26
mo271 pushed a commit that referenced this pull request Feb 18, 2023
@thorimur @mcdoll
@xroblot @mo271
feat: port Data.Nat.Count (#2209)
8faff36 
Co-authored-by: Moritz Doll <moritz.doll@googlemail.com>
Co-authored-by: Xavier-François Roblot <46200072+xroblot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xroblot @semorrison @jcommelin @thorimur @mcdoll