Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port GroupTheory.Abelianization #2215

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - feat: port GroupTheory.Abelianization #2215

wants to merge 8 commits into from

Conversation

tb65536
Copy link
Collaborator

@tb65536 tb65536 commented Feb 11, 2023

Open in Gitpod

@tb65536
feat: port GroupTheory.Abelianization
5ae5ab2
@tb65536
Initial file copy from mathport
8dea94a
@tb65536
automated fixes
d32ae05 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@tb65536 tb65536 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Feb 11, 2023
@tb65536
Copy link
Collaborator Author

tb65536 commented Feb 11, 2023

There are a couple hacky changes that I made that someone more experienced should look over:

  • I wasn't able to get deriving Subgroup.Normal to work on line 40 and had to add the instance manually,
  • I had to add [Group G] on line 207

@tb65536 tb65536 added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Feb 11, 2023
@jcommelin
Copy link
Member

Please add -- Porting notes for both of the issues you mention.

jcommelin
jcommelin approved these changes Feb 11, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 11, 2023
bors bot pushed a commit that referenced this pull request Feb 11, 2023
@tb65536
feat: port GroupTheory.Abelianization (#2215)
b10c1d7
@bors
Copy link

bors bot commented Feb 11, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port GroupTheory.Abelianization [Merged by Bors] - feat: port GroupTheory.Abelianization Feb 11, 2023
@bors bors bot closed this Feb 11, 2023
@bors bors bot deleted the port/GroupTheory.Abelianization branch February 11, 2023 21:47
mo271 pushed a commit that referenced this pull request Feb 12, 2023
@tb65536 @mo271
feat: port GroupTheory.Abelianization (#2215)
6a296e3
mo271 pushed a commit that referenced this pull request Feb 18, 2023
@tb65536 @mo271
feat: port GroupTheory.Abelianization (#2215)
ace12ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tb65536 @jcommelin @semorrison