Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port SetTheory.Ordinal.Basic #2217

Closed
wants to merge 12 commits into from
Closed

[Merged by Bors] - feat: port SetTheory.Ordinal.Basic #2217

wants to merge 12 commits into from

Conversation

LukasMias
Copy link
Collaborator

@LukasMias LukasMias commented Feb 11, 2023 •
edited

Needed to add some explicit universes here and there, add some _aux simp lemmas, and reformat some funky inductions. What is unfortunate is that succ_one : succ (1 : Ordinal) = 2 is not true by rfl anymore.

Open in Gitpod

@LukasMias
feat: port SetTheory.Ordinal.Basic
2ea2dca
@LukasMias
Initial file copy from mathport
9959cfe
@LukasMias
automated fixes
6285b98 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@LukasMias LukasMias added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Feb 11, 2023
@LukasMias LukasMias added help-wanted The author needs attention to resolve issues WIP Work in progress and removed WIP Work in progress labels Feb 12, 2023
@LukasMias LukasMias added awaiting-review The author would like community review of the PR WIP Work in progress and removed help-wanted The author needs attention to resolve issues WIP Work in progress awaiting-review The author would like community review of the PR labels Feb 12, 2023
@LukasMias LukasMias added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Feb 12, 2023
jcommelin
jcommelin approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 13, 2023
bors bot pushed a commit that referenced this pull request Feb 13, 2023
@LukasMias
feat: port SetTheory.Ordinal.Basic (#2217)
c9623a9 
Needed to add some explicit universes here and there, add some `_aux` simp lemmas, and reformat some funky inductions. What is unfortunate is that `succ_one : succ (1 : Ordinal) = 2` is not true by `rfl` anymore.
@bors
Copy link

bors bot commented Feb 13, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port SetTheory.Ordinal.Basic [Merged by Bors] - feat: port SetTheory.Ordinal.Basic Feb 13, 2023
@bors bors bot closed this Feb 13, 2023
@bors bors bot deleted the port/SetTheory.Ordinal.Basic branch February 13, 2023 06:51
mo271 pushed a commit that referenced this pull request Feb 18, 2023
@LukasMias @mo271
feat: port SetTheory.Ordinal.Basic (#2217)
3a2887f 
Needed to add some explicit universes here and there, add some `_aux` simp lemmas, and reformat some funky inductions. What is unfortunate is that `succ_one : succ (1 : Ordinal) = 2` is not true by `rfl` anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LukasMias @jcommelin @semorrison