Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port CategoryTheory.Bicategory.Strict #2218

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat: port CategoryTheory.Bicategory.Strict #2218

wants to merge 6 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented Feb 11, 2023

Open in Gitpod

@mo271
feat: port CategoryTheory.Bicategory.Strict
bf2b159
@mo271
Initial file copy from mathport
c08c836
@mo271
automated fixes
21098db 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@mo271
first pass
99671e3
@mo271 mo271 added the mathlib-port This is a port of a theory file from mathlib. label Feb 11, 2023
@mo271 mo271 added the WIP Work in progress label Feb 11, 2023
@mo271
Copy link
Collaborator Author

mo271 commented Feb 11, 2023

Things that came up:

  • some restate axiom were removed and id_comp' transformed id_comp
  • the linter reported 3 "simp can prove that" for
    • Bicategory.Strict.id_comp
    • Bicategory.Strict.comp_id
    • Bicategory.Strict.assoc

@mo271 mo271 added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Feb 11, 2023
jcommelin
jcommelin approved these changes Feb 11, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 11, 2023
bors bot pushed a commit that referenced this pull request Feb 11, 2023
@mo271
feat: port CategoryTheory.Bicategory.Strict (#2218)
71d0719 
Co-authored-by: Moritz Firsching <firsching@google.com>
@bors
Copy link

bors bot commented Feb 11, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port CategoryTheory.Bicategory.Strict [Merged by Bors] - feat: port CategoryTheory.Bicategory.Strict Feb 11, 2023
@bors bors bot closed this Feb 11, 2023
@bors bors bot deleted the port/CategoryTheory.Bicategory.Strict branch February 11, 2023 21:56
mo271 added a commit that referenced this pull request Feb 12, 2023
@mo271
feat: port CategoryTheory.Bicategory.Strict (#2218)
0ddb44e 
Co-authored-by: Moritz Firsching <firsching@google.com>
mo271 added a commit that referenced this pull request Feb 18, 2023
@mo271
feat: port CategoryTheory.Bicategory.Strict (#2218)
e539e67 
Co-authored-by: Moritz Firsching <firsching@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mo271 @jcommelin @semorrison