Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port GroupTheory.Solvable #2221

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat: port GroupTheory.Solvable #2221

wants to merge 9 commits into from

Conversation

tb65536
Copy link
Collaborator

@tb65536 tb65536 commented Feb 12, 2023

Open in Gitpod

@tb65536
feat: port GroupTheory.Solvable
4bf4c81
@tb65536
Initial file copy from mathport
5f19aff
@tb65536
automated fixes
fa3bb40 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@tb65536
first round of fixes
4da834e
@tb65536 tb65536 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Feb 12, 2023
@tb65536 tb65536 added awaiting-review The author would like community review of the PR and removed WIP Work in progress awaiting-CI labels Mar 4, 2023
@urkud
Copy link
Member

urkud commented Mar 5, 2023

Otherwise LGTM. Thanks! 🎉
bors d+

@bors
Copy link

bors bot commented Mar 5, 2023

✌️ tb65536 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Mar 5, 2023
@tb65536
Copy link
Collaborator Author

tb65536 commented Mar 6, 2023

bors r+

bors bot pushed a commit that referenced this pull request Mar 6, 2023
@tb65536
feat: port GroupTheory.Solvable (#2221)
5c44c6f
@bors
Copy link

bors bot commented Mar 6, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port GroupTheory.Solvable [Merged by Bors] - feat: port GroupTheory.Solvable Mar 6, 2023
@bors bors bot closed this Mar 6, 2023
@bors bors bot deleted the port/GroupTheory.Solvable branch March 6, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urkud urkud urkud left review comments

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tb65536 @urkud