Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat port/CategoryTheory.Pi.Basic #2230

Closed
wants to merge 14 commits into from
Closed

[Merged by Bors] - feat port/CategoryTheory.Pi.Basic #2230

wants to merge 14 commits into from

Conversation

mattrobball
Copy link
Collaborator

@mattrobball mattrobball commented Feb 12, 2023 •
edited

Open in Gitpod

@mattrobball
feat: port CategoryTheory.Pi.Basic
b3e68ca
@mattrobball
Initial file copy from mathport
8414826
@mattrobball
automated fixes
a4ea90f 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@mattrobball
fix some errors
8136307
@mattrobball mattrobball added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Feb 12, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 14, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 14, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 14, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 14, 2023
@mattrobball mattrobball added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Feb 14, 2023
@mattrobball mattrobball mentioned this pull request Feb 15, 2023
Closed
1 task
jcommelin
jcommelin reviewed Feb 15, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@bors
Copy link

bors bot commented Feb 15, 2023

✌️ mattrobball can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Feb 15, 2023
@mattrobball
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Feb 15, 2023
@mattrobball
feat port/CategoryTheory.Pi.Basic (#2230)
f52a095
@bors
Copy link

bors bot commented Feb 15, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat port/CategoryTheory.Pi.Basic [Merged by Bors] - feat port/CategoryTheory.Pi.Basic Feb 15, 2023
@bors bors bot closed this Feb 15, 2023
@bors bors bot deleted the port/CategoryTheory.Pi.Basic branch February 15, 2023 05:03
mo271 pushed a commit that referenced this pull request Feb 18, 2023
@mattrobball @mo271
feat port/CategoryTheory.Pi.Basic (#2230)
3a07532
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mattrobball @jcommelin @semorrison