Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Topology.Algebra.Monoid #2245

Closed
wants to merge 17 commits into from
Closed

[Merged by Bors] - feat: port Topology.Algebra.Monoid #2245

wants to merge 17 commits into from

Conversation

mcdoll
Copy link
Member

@mcdoll mcdoll commented Feb 13, 2023

Open in Gitpod

@mcdoll
feat: port Topology.Algebra.Monoid
848a55b
@mcdoll
Initial file copy from mathport
b3ae0ca
@mcdoll
automated fixes
d06a7ba 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@mcdoll mcdoll added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Feb 13, 2023
@mcdoll mcdoll added the help-wanted The author needs attention to resolve issues label Feb 14, 2023
mcdoll and others added 4 commits February 14, 2023 11:54
@mcdoll
fix docstrings
617aa95
@mcdoll @eric-wieser
Update Mathlib/Topology/Algebra/Monoid.lean
a8c4717 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@mcdoll @eric-wieser
Update Mathlib/Topology/Algebra/Monoid.lean
0797a17 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@mcdoll
simplify
26ee1d1
@mcdoll mcdoll added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues WIP Work in progress labels Feb 14, 2023
@mcdoll mcdoll mentioned this pull request Feb 14, 2023
Closed
1 task
dupuisf
dupuisf reviewed Feb 14, 2023
View reviewed changes
Mathlib/Topology/Algebra/Monoid.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Algebra/Monoid.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Algebra/Monoid.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Algebra/Monoid.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Algebra/Monoid.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Algebra/Monoid.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Algebra/Monoid.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Algebra/Monoid.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Algebra/Monoid.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Algebra/Monoid.lean Outdated Show resolved Hide resolved
dupuisf
dupuisf reviewed Feb 14, 2023
View reviewed changes
Mathlib/Topology/Algebra/Monoid.lean
Comment on lines +342 to +345
@[to_additive "Construct a bundled additive monoid homomorphism `M₁ →+ M₂` from a function `f`
and a proof that it belongs to the closure of the range of the coercion from `M₁ →+ M₂` (or another
type of bundled homomorphisms that has a `add_monoid_hom_class` instance) to `M₁ → M₂`.",
simps (config := { fullyApplied := false })]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this and the next one should also be converted to (attr := foo), but I'm not sure of the exact syntax.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to_additive (attr := simps (config := { fullyApplied := false })) "Construct..."

@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Feb 14, 2023
mcdoll and others added 2 commits February 14, 2023 23:04
@mcdoll @dupuisf
Apply suggestions from code review
3e4d9e3 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@mcdoll @dupuisf
Update Mathlib/Topology/Algebra/Monoid.lean
e3a437d 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
mcdoll
mcdoll commented Feb 14, 2023
View reviewed changes
Mathlib/Topology/Algebra/Monoid.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Algebra/Monoid.lean Outdated Show resolved Hide resolved
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 14, 2023
bors bot pushed a commit that referenced this pull request Feb 14, 2023
@mcdoll @eric-wieser @jcommelin
feat: port Topology.Algebra.Monoid (#2245)
f69c5e4 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Feb 14, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Topology.Algebra.Monoid [Merged by Bors] - feat: port Topology.Algebra.Monoid Feb 14, 2023
@bors bors bot closed this Feb 14, 2023
@bors bors bot deleted the port/Topology.Algebra.Monoid branch February 14, 2023 14:56
mo271 pushed a commit that referenced this pull request Feb 18, 2023
@mcdoll @eric-wieser
@jcommelin @mo271
feat: port Topology.Algebra.Monoid (#2245)
3e57c75 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urkud urkud urkud left review comments

@eric-wieser eric-wieser eric-wieser approved these changes

@dupuisf dupuisf dupuisf left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mcdoll @jcommelin @urkud @eric-wieser @dupuisf