Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port SetTheory.Ordinal.Arithmetic #2271

Closed
wants to merge 26 commits into from
Closed

[Merged by Bors] - feat: port SetTheory.Ordinal.Arithmetic #2271

wants to merge 26 commits into from

Conversation

jcommelin
Copy link
Member

Open in Gitpod

@jcommelin
feat: port SetTheory.Ordinal.Arithmetic
0579dc4
@jcommelin
Initial file copy from mathport
8cf0347
@jcommelin
automated fixes
6b9b0e0 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@jcommelin jcommelin added mathlib-port This is a port of a theory file from mathlib. help-wanted The author needs attention to resolve issues labels Feb 14, 2023
jcommelin
jcommelin commented Feb 16, 2023
View reviewed changes
Mathlib/SetTheory/Ordinal/Arithmetic.lean Outdated Show resolved Hide resolved
Mathlib/SetTheory/Ordinal/Arithmetic.lean Outdated Show resolved Hide resolved
Komyyy and others added 2 commits February 16, 2023 17:55
@Komyyy @jcommelin
suggestion 1
83f5854 
Co-authored-by: Johan Commelin <johan@commelin.net>
@Komyyy @jcommelin
suggestion 2
e926d81 
Co-authored-by: Johan Commelin <johan@commelin.net>
@jcommelin
Copy link
Member Author

Great work! Thanks so much for your help @Komyyy

bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Feb 16, 2023
bors bot pushed a commit that referenced this pull request Feb 16, 2023
@jcommelin @qawbecrdtey
@eric-wieser @Komyyy
feat: port SetTheory.Ordinal.Arithmetic (#2271)
b9f402c 
Co-authored-by: qawbecrdtey <qawbecrdtey@naver.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Komyyy <pol_tta@outlook.jp>
Co-authored-by: Pol_tta <52843868+Komyyy@users.noreply.github.com>
@bors
Copy link

bors bot commented Feb 16, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port SetTheory.Ordinal.Arithmetic [Merged by Bors] - feat: port SetTheory.Ordinal.Arithmetic Feb 16, 2023
@bors bors bot closed this Feb 16, 2023
@bors bors bot deleted the port/SetTheory.Ordinal.Arithmetic branch February 16, 2023 09:11
mo271 pushed a commit that referenced this pull request Feb 18, 2023
@jcommelin @qawbecrdtey
@eric-wieser @Komyyy @mo271
feat: port SetTheory.Ordinal.Arithmetic (#2271)
2f15e1a 
Co-authored-by: qawbecrdtey <qawbecrdtey@naver.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Komyyy <pol_tta@outlook.jp>
Co-authored-by: Pol_tta <52843868+Komyyy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Komyyy Komyyy Komyyy left review comments

Assignees
No one assigned
Labels
help-wanted The author needs attention to resolve issues mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jcommelin @Komyyy @qawbecrdtey @eric-wieser