Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Algebra.Module.Submodule.Pointwise #2285

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat: port Algebra.Module.Submodule.Pointwise #2285

wants to merge 7 commits into from

Conversation

j-loreaux
Copy link
Collaborator

Open in Gitpod

@j-loreaux
feat: port Algebra.Module.Submodule.Pointwise
148bafc
@j-loreaux
Initial file copy from mathport
57b09f7
@j-loreaux
automated fixes
7bcbbe2 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@j-loreaux j-loreaux added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Feb 14, 2023
@j-loreaux j-loreaux added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Feb 14, 2023
dupuisf
dupuisf reviewed Feb 14, 2023
View reviewed changes
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 14, 2023
bors bot pushed a commit that referenced this pull request Feb 14, 2023
@j-loreaux
feat: port Algebra.Module.Submodule.Pointwise (#2285)
b01f03c
@bors
Copy link

bors bot commented Feb 14, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Algebra.Module.Submodule.Pointwise [Merged by Bors] - feat: port Algebra.Module.Submodule.Pointwise Feb 14, 2023
@bors bors bot closed this Feb 14, 2023
@bors bors bot deleted the port/Algebra.Module.Submodule.Pointwise branch February 14, 2023 23:56
mo271 pushed a commit that referenced this pull request Feb 18, 2023
@j-loreaux @mo271
feat: port Algebra.Module.Submodule.Pointwise (#2285)
06abd37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dupuisf dupuisf dupuisf left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@j-loreaux @dupuisf @semorrison