[Merged by Bors] - feat: port Logic.Hydra #2290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
urkud
commented
Feb 14, 2023
urkud
commented
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
semorrison
added
awaiting-author
semorrison
removed
the
merge-conflict
int-y1
added
awaiting-review
semorrison
reviewed
Apr 3, 2023
Mathlib/Logic/Hydra.lean
Outdated
| convert (add_zero _).symm | ||
| exact count_eq_zero.2 fun ha => hi.irrefl a <| hr a ha | ||
| refine ⟨a, fun b h ↦ ?_, ?_⟩ <;> simp_rw [toFinsupp_apply] | ||
| · replace he := congr_arg (count b) he -- porting note: was apply_fun count b at he |
There was a problem hiding this comment.
In fact, apply_fun has been improved in the meantime, and works here. (Also a few lines below.)
semorrison
reviewed
Apr 3, 2023
|
bors r+ |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Apr 3, 2023
Co-authored-by: Jason Yuen <jason_yuen2007@hotmail.com> Co-authored-by: int-y1 <jason_yuen2007@hotmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
MonadMaverick
pushed a commit
that referenced
this pull request
Apr 9, 2023
Co-authored-by: Jason Yuen <jason_yuen2007@hotmail.com> Co-authored-by: int-y1 <jason_yuen2007@hotmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
MonadMaverick
pushed a commit
to MonadMaverick/mathlib4
that referenced
this pull request
Apr 9, 2023
Co-authored-by: Jason Yuen <jason_yuen2007@hotmail.com> Co-authored-by: int-y1 <jason_yuen2007@hotmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.