Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Nat.Nth #2297

Closed
wants to merge 12 commits into from
Closed

[Merged by Bors] - feat: port Data.Nat.Nth #2297

wants to merge 12 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Feb 15, 2023 •
edited by github-actions bot

@urkud urkud added help-wanted The author needs attention to resolve issues please-adopt mathlib-port This is a port of a theory file from mathlib. and removed help-wanted The author needs attention to resolve issues please-adopt labels Feb 15, 2023
@urkud
Copy link
Member Author

urkud commented Feb 15, 2023

@mo271 Are you working on this now? If no, then I'm going to fix the rest.

@mo271
Copy link
Collaborator

mo271 commented Feb 15, 2023

@mo271 Are you working on this now? If no, then I'm going to fix the rest.

@urkud go ahead, I'm not working on it right now..

@urkud
Copy link
Member Author

urkud commented Feb 16, 2023

I fixed compile but I failed to stop myself from reviewing proofs/API. Now I'm going to split this PR into easily reviewable chunks.

@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 19, 2023
@semorrison semorrison added merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Mar 23, 2023
@semorrison semorrison added blocked-by-other-PR This PR depends on another PR which is still in the queue. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Apr 20, 2023
@YaelDillies
Copy link
Collaborator

Could you update the SHA?

@eric-wieser
Copy link
Member

To what? We're still waiting for #18760

@urkud
Copy link
Member Author

urkud commented May 2, 2023

@YaelDillies It makes no sense to update this branch because I'm going to restart it once leanprover-community/mathlib#18760 is merged.

@YaelDillies
Copy link
Collaborator

It makes sense to me because it was costing us one file out of 20 on our out-of-sync budget 😛

@collares collares mentioned this pull request May 31, 2023
Closed
1 task
@semorrison semorrison added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Jun 14, 2023
@semorrison semorrison added merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. labels Jun 15, 2023
@urkud
Copy link
Member Author

urkud commented Jun 15, 2023

I'm going to rebase today. Please don't merge master.

@urkud
feat: port Data.Nat.Nth
3de1122
@urkud
Initial file copy from mathport
c55dc7c
@urkud
automated fixes
be491a4 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jun 15, 2023
Ruben-VandeVelde
Ruben-VandeVelde reviewed Jun 16, 2023
View reviewed changes
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if you can restore push_neg; lgtm otherwise. Could you mark as awaiting-review if you agree?

Mathlib/Data/Nat/Nth.lean Outdated Show resolved Hide resolved
@Komyyy Komyyy added bug Something isn't working WIP Work in progress labels Jun 19, 2023
@Komyyy Komyyy added blocked-by-other-PR This PR depends on another PR which is still in the queue. and removed bug Something isn't working WIP Work in progress labels Jun 19, 2023
@semorrison semorrison removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Jun 21, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@Komyyy Komyyy added awaiting-review The author would like community review of the PR awaiting-CI labels Jun 21, 2023
@ChrisHughes24
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 21, 2023
bors bot pushed a commit that referenced this pull request Jun 21, 2023
@urkud @Komyyy
feat: port Data.Nat.Nth (#2297)
615e31f 
Co-authored-by: Komyyy <pol_tta@outlook.jp>
@bors
Copy link

bors bot commented Jun 21, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Data.Nat.Nth [Merged by Bors] - feat: port Data.Nat.Nth Jun 21, 2023
@bors bors bot closed this Jun 21, 2023
@bors bors bot deleted the port/Data.Nat.Nth branch June 21, 2023 10:46
alexkeizer pushed a commit that referenced this pull request Jun 22, 2023
@urkud @Komyyy @alexkeizer
feat: port Data.Nat.Nth (#2297)
4fade38 
Co-authored-by: Komyyy <pol_tta@outlook.jp>
semorrison pushed a commit that referenced this pull request Jun 23, 2023
@urkud @Komyyy @semorrison
feat: port Data.Nat.Nth (#2297)
c20a99f 
Co-authored-by: Komyyy <pol_tta@outlook.jp>
semorrison pushed a commit that referenced this pull request Jun 23, 2023
@urkud @Komyyy @semorrison
feat: port Data.Nat.Nth (#2297)
e7e184e 
Co-authored-by: Komyyy <pol_tta@outlook.jp>
semorrison pushed a commit that referenced this pull request Jun 25, 2023
@urkud @Komyyy @semorrison
feat: port Data.Nat.Nth (#2297)
c534e06 
Co-authored-by: Komyyy <pol_tta@outlook.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@Komyyy Komyyy Komyyy left review comments

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@urkud @mo271 @YaelDillies @eric-wieser @semorrison @ChrisHughes24 @Komyyy @Ruben-VandeVelde