Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix: undeprecate List.get_mono and List.get_strictMono #2308

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - fix: undeprecate List.get_mono and List.get_strictMono #2308

wants to merge 5 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Feb 16, 2023 •
edited by github-actions bot

I see no reason for these lemmas to be deprecated.

Open in Gitpod

@urkud
Copy link
Member Author

urkud commented Feb 16, 2023 •
edited

@Ruben-VandeVelde Could you please have a look? Did you make them deprecated accidentally or you have a reason? In the latter case, please add back @[deprecated] with a comment about the reason for deprecation. Is it because they use deprecated nthLe in the proof? As far as I understand, we should use set_option linter.deprecated false in, not @[deprecated] in this case.

@semorrison semorrison added blocked-by-other-PR This PR depends on another PR to Mathlib and removed blocked-by-other-PR This PR depends on another PR to Mathlib labels Feb 16, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@urkud urkud added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Feb 18, 2023
jcommelin
jcommelin approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 21, 2023
bors bot pushed a commit that referenced this pull request Feb 21, 2023
@urkud
fix: undeprecate List.get_mono and List.get_strictMono (#2308)
f9c6101 
I see no reason for these lemmas to be deprecated.
@bors
Copy link

bors bot commented Feb 21, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix: undeprecate List.get_mono and List.get_strictMono [Merged by Bors] - fix: undeprecate List.get_mono and List.get_strictMono Feb 21, 2023
@bors bors bot closed this Feb 21, 2023
@bors bors bot deleted the YK-get-depr branch February 21, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

@Ruben-VandeVelde Ruben-VandeVelde Awaiting requested review from Ruben-VandeVelde

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @semorrison @jcommelin