Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port CategoryTheory.Conj #2316

Closed
wants to merge 12 commits into from
Closed

[Merged by Bors] - feat: port CategoryTheory.Conj #2316

wants to merge 12 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented Feb 16, 2023

Open in Gitpod

@mo271
feat: port CategoryTheory.Conj
230e456
@mo271
Initial file copy from mathport
a7776e0
@mo271
automated fixes
c43b542 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@mo271
first pass
67379c9
@mo271 mo271 added mathlib-port This is a port of a theory file from mathlib. WIP Work in progress labels Feb 16, 2023
@mo271
Copy link
Collaborator Author

mo271 commented Feb 16, 2023

The only thing that is left is a non-working rfl in conjAut_apply

@mo271 mo271 added help-wanted The author needs attention to resolve issues and removed WIP Work in progress labels Feb 16, 2023
@mattrobball mattrobball added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues labels Feb 16, 2023
@mattrobball
Copy link
Collaborator

Should be ready to go.

urkud
urkud reviewed Feb 18, 2023
View reviewed changes
Copy link
Member

@urkud urkud left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have a few minor comments, otherwise LGTM.

Mathlib/CategoryTheory/Conj.lean Outdated Show resolved Hide resolved
Mathlib/CategoryTheory/Conj.lean Show resolved Hide resolved
Mathlib/CategoryTheory/Conj.lean Outdated Show resolved Hide resolved
Mathlib/CategoryTheory/Conj.lean Show resolved Hide resolved
@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Feb 18, 2023
@mo271 mo271 added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 18, 2023
jcommelin
jcommelin approved these changes Feb 18, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 18, 2023
bors bot pushed a commit that referenced this pull request Feb 18, 2023
@mo271 @mattrobball
feat: port CategoryTheory.Conj (#2316)
876c87c 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: Matthew Ballard <matt@mrb.email>
@bors
Copy link

bors bot commented Feb 18, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port CategoryTheory.Conj [Merged by Bors] - feat: port CategoryTheory.Conj Feb 18, 2023
@bors bors bot closed this Feb 18, 2023
@bors bors bot deleted the port/CategoryTheory.Conj branch February 18, 2023 19:02
mo271 added a commit that referenced this pull request Feb 18, 2023
@mo271 @mattrobball
feat: port CategoryTheory.Conj (#2316)
307e1f9 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: Matthew Ballard <matt@mrb.email>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urkud urkud urkud left review comments

@mattrobball mattrobball mattrobball left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mo271 @mattrobball @urkud @jcommelin @semorrison