Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Order.Extension.Well #2333

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat: port Order.Extension.Well #2333

wants to merge 6 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Feb 17, 2023

Open in Gitpod

@urkud
feat: port Order.Extension.Well
cc3d2c1
@urkud
Initial file copy from mathport
b170bb2
@urkud
automated fixes
5f97b19 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@urkud
Fix
5f3f328
@urkud
auto: naming
e914cb5
@urkud urkud added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. labels Feb 17, 2023
ChrisHughes24
ChrisHughes24 approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@ChrisHughes24 ChrisHughes24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the porting note is changed

bors d+

Mathlib/Order/Extension/Well.lean Outdated
Comment on lines 32 to 33
The definition in `mathlib` 3 used an auxiliary well-founded order on `α` lifted from `Cardinal`
instead of `Cardinal`. The new definition is definitionally equal to the `mathlib` 3 version but
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this porting note.

@bors
Copy link

bors bot commented Feb 17, 2023

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Feb 17, 2023
@urkud
Copy link
Member Author

urkud commented Feb 18, 2023

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Feb 18, 2023
bors bot pushed a commit that referenced this pull request Feb 18, 2023
@urkud
feat: port Order.Extension.Well (#2333)
1912e88
@bors
Copy link

bors bot commented Feb 18, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Order.Extension.Well [Merged by Bors] - feat: port Order.Extension.Well Feb 18, 2023
@bors bors bot closed this Feb 18, 2023
@bors bors bot deleted the port/Order.Extension.Well branch February 18, 2023 05:54
mo271 pushed a commit that referenced this pull request Feb 18, 2023
@urkud @mo271
feat: port Order.Extension.Well (#2333)
8ac0192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisHughes24 ChrisHughes24 ChrisHughes24 approved these changes

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @ChrisHughes24 @semorrison