Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Order.PrimeIdeal #2352

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat: port Order.PrimeIdeal #2352

wants to merge 6 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Feb 17, 2023 •
edited by github-actions bot

@semorrison semorrison added blocked-by-math-PR This PR depends on another PR to Mathlib and removed blocked-by-math-PR This PR depends on another PR to Mathlib labels Feb 17, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

jcommelin
jcommelin reviewed Feb 18, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors d+

@bors
Copy link

bors bot commented Feb 18, 2023

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@urkud
feat: port Order.PrimeIdeal
2abacbe
@urkud
Initial file copy from mathport
7d761bc
@urkud
automated fixes
4250d80 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@urkud
Fix import
5b70524
@urkud
Fix compile
2f1ad3d
@urkud
auto: naming
c4333dd
@urkud
Copy link
Member Author

urkud commented Feb 18, 2023

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Feb 18, 2023
bors bot pushed a commit that referenced this pull request Feb 18, 2023
@urkud
feat: port Order.PrimeIdeal (#2352)
2657489
@bors
Copy link

bors bot commented Feb 18, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Order.PrimeIdeal [Merged by Bors] - feat: port Order.PrimeIdeal Feb 18, 2023
@bors bors bot closed this Feb 18, 2023
@bors bors bot deleted the port/Order.PrimeIdeal branch February 18, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
delegated ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @semorrison @jcommelin