Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Deprecated.Subring #2355

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat: port Deprecated.Subring #2355

wants to merge 7 commits into from

Conversation

int-y1
Copy link
Collaborator

@int-y1 int-y1 commented Feb 18, 2023

Open in Gitpod

@int-y1
feat: port Deprecated.Subring
8e43ef6
@int-y1
Initial file copy from mathport
bd7bec7
@int-y1
automated fixes
2301834 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@int-y1
fix errors
b018108
@int-y1
cleanup
7ed98a0
@int-y1 int-y1 added the mathlib-port This is a port of a theory file from mathlib. label Feb 18, 2023
@int-y1 int-y1 added the awaiting-review The author would like community review of the PR label Feb 18, 2023
jcommelin
jcommelin approved these changes Feb 18, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 18, 2023
bors bot pushed a commit that referenced this pull request Feb 18, 2023
@int-y1
feat: port Deprecated.Subring (#2355)
3b6ff86
@bors
Copy link

bors bot commented Feb 18, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Deprecated.Subring [Merged by Bors] - feat: port Deprecated.Subring Feb 18, 2023
@bors bors bot closed this Feb 18, 2023
@bors bors bot deleted the port/Deprecated.Subring branch February 18, 2023 18:52
mo271 pushed a commit that referenced this pull request Feb 18, 2023
@int-y1 @mo271
feat: port Deprecated.Subring (#2355)
532119e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@int-y1 @jcommelin @semorrison