Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix: category_theory -> CategoryTheory in note #2357

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - fix: category_theory -> CategoryTheory in note #2357

wants to merge 2 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented Feb 18, 2023

This changes the name of a library_note from
"category_theory universes" to
"CategoryTheory universes"
to be more in line with the new naming conventions.

Open in Gitpod

@mo271
fix: category_theory -> CategoryTheory in note
56e6055 
This changes the name of a library_note from
"category_theory universes" to
"CategoryTheory universes"
to be more in line with the new naming conventions.
@mo271 mo271 added documentation Improvements or additions to documentation awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Feb 18, 2023
@mo271
Copy link
Collaborator Author

mo271 commented Feb 18, 2023

I checked for other occurrences of new names used in a library_note but didn't find any

dupuisf
dupuisf reviewed Feb 18, 2023
View reviewed changes
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 18, 2023
bors bot pushed a commit that referenced this pull request Feb 18, 2023
@mo271
fix: category_theory -> CategoryTheory in note (#2357)
e9da87a 
This changes the name of a library_note from
"category_theory universes" to
"CategoryTheory universes"
to be more in line with the new naming conventions.



Co-authored-by: Moritz Firsching <firsching@google.com>
@bors
Copy link

bors bot commented Feb 18, 2023

Build failed:

  • Build

@mo271
Copy link
Collaborator Author

mo271 commented Feb 18, 2023

I can't see Details for the bors — Build failed run, but https://github.com/leanprover-community/mathlib4/actions/runs/4211872392/jobs/7310499221 it seems like some caching was not working as intented. Seems unrelated to the pull request at hand, perhaps we can try again to
bors r+

@bors
Copy link

bors bot commented Feb 18, 2023

🔒 Permission denied

Existing reviewers: click here to make mo271 a reviewer

@mo271 mo271 added awaiting-review The author would like community review of the PR and removed easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. labels Feb 18, 2023
@mo271 mo271 requested a review from dupuisf February 25, 2023 15:11
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 2, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 2, 2023
@jcommelin
Copy link
Member

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 2, 2023
bors bot pushed a commit that referenced this pull request Mar 2, 2023
@mo271
fix: category_theory -> CategoryTheory in note (#2357)
1640c54 
This changes the name of a library_note from
"category_theory universes" to
"CategoryTheory universes"
to be more in line with the new naming conventions.



Co-authored-by: Moritz Firsching <firsching@google.com>
@bors
Copy link

bors bot commented Mar 2, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix: category_theory -> CategoryTheory in note [Merged by Bors] - fix: category_theory -> CategoryTheory in note Mar 2, 2023
@bors bors bot closed this Mar 2, 2023
@bors bors bot deleted the fix/note_names branch March 2, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dupuisf dupuisf Awaiting requested review from dupuisf

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mo271 @jcommelin @dupuisf @semorrison