Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port/CategoryTheory.PEmpty #2363

Closed
wants to merge 19 commits into from

Conversation

mattrobball
Copy link
Collaborator

@mattrobball mattrobball commented Feb 18, 2023

@mattrobball mattrobball added the mathlib-port This is a port of a theory file from mathlib. label Feb 18, 2023
@semorrison semorrison added blocked-by-other-PR This PR depends on another PR which is still in the queue. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. labels Feb 18, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 21, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 21, 2023
@mattrobball mattrobball added the awaiting-review The author would like community review of the PR label Feb 21, 2023
@mattrobball
Copy link
Collaborator Author

Unblocked by DiscreteCategory and should be good to go.

Note: this file, despite its length, puts serious strain on Lean

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please leave a porting note in the file about the strain placed on Lean?

bors d+

Comment on lines 20 to 22
universe w v u

-- morphism levels before object levels. See note [CategoryTheory universes].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
universe w v u
-- morphism levels before object levels. See note [CategoryTheory universes].
universe w v u
-- morphism levels before object levels. See note [CategoryTheory universes].

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@bors
Copy link

bors bot commented Feb 21, 2023

✌️ mattrobball can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Feb 21, 2023
@mattrobball
Copy link
Collaborator Author

Could you please leave a porting note in the file about the strain placed on Lean?

Added a note at the top. Thought I’ve since found a worse one 😧

@mattrobball
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Feb 21, 2023
Co-authored-by: Matthew Ballard <matt@mrb.email>
Co-authored-by: Matthew Robert Ballard <100034030+mattrobball@users.noreply.github.com>
@bors
Copy link

bors bot commented Feb 21, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port/CategoryTheory.PEmpty [Merged by Bors] - feat: port/CategoryTheory.PEmpty Feb 21, 2023
@bors bors bot closed this Feb 21, 2023
@bors bors bot deleted the port/CategoryTheory.Pempty branch February 21, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants