Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Geometry.Manifold.ChartedSpace #2365

Closed
wants to merge 13 commits into from
Closed

[Merged by Bors] - feat: port Geometry.Manifold.ChartedSpace #2365

wants to merge 13 commits into from

Conversation

int-y1
Copy link
Collaborator

@int-y1 int-y1 commented Feb 19, 2023

Open in Gitpod

@int-y1 int-y1 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Feb 19, 2023
@int-y1 int-y1 changed the title Port/geometry.manifold.charted space feat: port Geometry.Manifold.ChartedSpace Feb 19, 2023
@int-y1
Copy link
Collaborator Author

int-y1 commented Feb 19, 2023

2 linter messages left:

  • Linter failed on Pregroupoid.mk.injEq because of the heartbeat limit
  • simpNF linter on theorem modelProd_range_prod_id

@int-y1 int-y1 added help-wanted The author needs attention to resolve issues and removed WIP Work in progress labels Feb 19, 2023
@arienmalec
Copy link
Collaborator

2 linter messages left:

* Linter failed on `Pregroupoid.mk.injEq` because of the heartbeat limit

* simpNF linter on `theorem modelProd_range_prod_id`

I'm not sure what the simpNF linter is trying to say for modelProd_range_prod_id because this works...

theorem modelProd_range_prod_id' {H : Type _} {H' : Type _} {α : Type _} (f : H → α) :
    (range fun p : ModelProd H H' ↦ (f p.1, p.2)) = range f ×ˢ (univ : Set H') := by
  simp only [modelProd_range_prod_id]

@semorrison semorrison added merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Feb 22, 2023
@Ruben-VandeVelde Ruben-VandeVelde force-pushed the port/Geometry.Manifold.ChartedSpace branch from 80d6a3f to 60e0bab Compare April 10, 2023 13:24
@Ruben-VandeVelde Ruben-VandeVelde added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues labels Apr 10, 2023
@Ruben-VandeVelde Ruben-VandeVelde added WIP Work in progress help-wanted The author needs attention to resolve issues and removed awaiting-review The author would like community review of the PR labels Apr 10, 2023
@Ruben-VandeVelde Ruben-VandeVelde removed help-wanted The author needs attention to resolve issues WIP Work in progress labels Apr 11, 2023
@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-review The author would like community review of the PR label Apr 11, 2023
@ChrisHughes24
Copy link
Member

bors merge

bors bot pushed a commit that referenced this pull request Apr 11, 2023
@Ruben-VandeVelde @int-y1
feat: port Geometry.Manifold.ChartedSpace (#2365)
814b0c4 
Co-authored-by: int-y1 <jason_yuen2007@hotmail.com>
@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Apr 11, 2023
@bors
Copy link

bors bot commented Apr 11, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Geometry.Manifold.ChartedSpace [Merged by Bors] - feat: port Geometry.Manifold.ChartedSpace Apr 11, 2023
@bors bors bot closed this Apr 11, 2023
@bors bors bot deleted the port/Geometry.Manifold.ChartedSpace branch April 11, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@int-y1 @arienmalec @ChrisHughes24 @semorrison @Ruben-VandeVelde