Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port LinearAlgebra.QuotientPi #2378

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat: port LinearAlgebra.QuotientPi #2378

wants to merge 6 commits into from

Conversation

4e554c4c
Copy link
Collaborator

Open in Gitpod

@4e554c4c 4e554c4c added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Feb 19, 2023
@4e554c4c
Copy link
Collaborator Author

4e554c4c commented Feb 19, 2023 •
edited
Loading

appears to be blocked by leanprover/lean4#2074

edit: no longer blocked after attribute [-instance] Ring.toNonAssocRing

@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 27, 2023
@4e554c4c 4e554c4c added the help-wanted The author needs attention to resolve issues label Mar 11, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 11, 2023
@4e554c4c
Copy link
Collaborator Author

help is wanted to speed up the last definition so that a timout bump isn't needed. See https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/LinearAlgebra.2EQuotientPi.20!4.232378 for more info.

Ruben-VandeVelde and others added 5 commits April 10, 2023 15:46
@Ruben-VandeVelde
feat: port LinearAlgebra.QuotientPi
ee021fa
@Ruben-VandeVelde
Initial file copy from mathport
30d522b
@Ruben-VandeVelde
automated fixes
0f066a8 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@4e554c4c @Ruben-VandeVelde
fixes
bc903aa 
currently builds but requires a timeout addition
@Ruben-VandeVelde
Split up definition
86b4c9d
@Ruben-VandeVelde Ruben-VandeVelde added awaiting-review and removed help-wanted The author needs attention to resolve issues WIP Work in progress labels Apr 10, 2023
@ChrisHughes24
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Apr 11, 2023
bors bot pushed a commit that referenced this pull request Apr 11, 2023
@Ruben-VandeVelde @4e554c4c @ChrisHughes24
feat: port LinearAlgebra.QuotientPi (#2378)
52d82e9 
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Calvin Lee <calvins.lee@utah.edu>
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
@bors
Copy link

bors bot commented Apr 11, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port LinearAlgebra.QuotientPi [Merged by Bors] - feat: port LinearAlgebra.QuotientPi Apr 11, 2023
@bors bors bot closed this Apr 11, 2023
@bors bors bot deleted the port/LinearAlgebra.QuotientPi branch April 11, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@4e554c4c @ChrisHughes24 @semorrison @Ruben-VandeVelde