Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port FieldTheory.Subfield #2395

Closed
wants to merge 10 commits into from
Closed

[Merged by Bors] - feat: port FieldTheory.Subfield #2395

wants to merge 10 commits into from

Conversation

LukasMias
Copy link
Collaborator

@LukasMias LukasMias commented Feb 20, 2023 •
edited

Needed to fix some mistranslation in another file but then it's smooth sailing.

Open in Gitpod

@LukasMias
feat: port FieldTheory.Subfield
d2f1d28
@LukasMias
Initial file copy from mathport
c0dbcde
@LukasMias
automated fixes
c875ce1 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@LukasMias LukasMias added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Feb 20, 2023
@LukasMias LukasMias added the help-wanted The author needs attention to resolve issues label Feb 22, 2023
@LukasMias
Copy link
Collaborator Author

Oof, sorry for the slow progress, meant to add the #help-wanted tag three times now but goblins in my internet cables must have prevented it.

@LukasMias LukasMias added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues WIP Work in progress labels Feb 22, 2023
jcommelin
jcommelin approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 22, 2023
bors bot pushed a commit that referenced this pull request Feb 22, 2023
@LukasMias
feat: port FieldTheory.Subfield (#2395)
d0316d4 
Needed to fix some mistranslation in another file but then it's smooth sailing.
@bors
Copy link

bors bot commented Feb 22, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port FieldTheory.Subfield [Merged by Bors] - feat: port FieldTheory.Subfield Feb 22, 2023
@bors bors bot closed this Feb 22, 2023
@bors bors bot deleted the port/FieldTheory.Subfield branch February 22, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LukasMias @jcommelin @semorrison