Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: Port/Data.QPF.Multivariate.Constructions.Fix #2409

Closed
wants to merge 20 commits into from
Closed

[Merged by Bors] - feat: Port/Data.QPF.Multivariate.Constructions.Fix #2409

wants to merge 20 commits into from

Conversation

arienmalec
Copy link
Collaborator

Open in Gitpod

@arienmalec
feat: port Data.Qpf.Multivariate.Constructions.Fix
746ce0d
@arienmalec
Initial file copy from mathport
3146fca
@arienmalec
automated fixes
915963c 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@arienmalec
easy fixes
3c21714
@arienmalec arienmalec added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Feb 21, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 21, 2023
@arienmalec arienmalec added help-wanted The author needs attention to resolve issues and removed WIP Work in progress labels Feb 21, 2023
@arienmalec arienmalec removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 21, 2023
@casavaca
Copy link
Collaborator

Pushed a small change to make it build.

@arienmalec arienmalec added awaiting-review and removed help-wanted The author needs attention to resolve issues labels Feb 22, 2023
arienmalec and others added 4 commits February 22, 2023 11:58
@arienmalec @alexkeizer
naming consistency
6ecd1b1 
Co-authored-by: Alex Keizer <alex@keizer.dev>
@arienmalec @alexkeizer
naming consistency
b906fc8 
Co-authored-by: Alex Keizer <alex@keizer.dev>
@arienmalec
naming consistency
a70f42e
@arienmalec
naming consistency
1f69e54
jcommelin
jcommelin approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Feb 23, 2023
bors bot pushed a commit that referenced this pull request Feb 23, 2023
@arienmalec @casavaca @alexkeizer
feat: Port/Data.QPF.Multivariate.Constructions.Fix (#2409)
6ae4a72 



Co-authored-by: casavaca <96765450+casavaca@users.noreply.github.com>
Co-authored-by: Alex Keizer <alex@keizer.dev>
@bors
Copy link

bors bot commented Feb 23, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: Port/Data.QPF.Multivariate.Constructions.Fix [Merged by Bors] - feat: Port/Data.QPF.Multivariate.Constructions.Fix Feb 23, 2023
@bors bors bot closed this Feb 23, 2023
@bors bors bot deleted the port/Data.Qpf.Multivariate.Constructions.Fix branch February 23, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkeizer alexkeizer alexkeizer left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@arienmalec @casavaca @jcommelin @alexkeizer @semorrison