Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: Port Topology.Algebra.Order.Group #2426

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat: Port Topology.Algebra.Order.Group #2426

wants to merge 4 commits into from

Conversation

casavaca
Copy link
Collaborator

Rename only.

Open in Gitpod

@casavaca
feat: port Topology.Algebra.Order.Group
9c218ff
@casavaca
Initial file copy from mathport
ad73f82
@casavaca
automated fixes
301a430 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@casavaca
Rename only
c54a753
@casavaca casavaca added mathlib-port This is a port of a theory file from mathlib. awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Feb 22, 2023
dupuisf
dupuisf reviewed Feb 22, 2023
View reviewed changes
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

Mathlib/Topology/Algebra/Order/Group.lean Show resolved Hide resolved
@bors
Copy link

bors bot commented Feb 22, 2023

✌️ casavaca can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Feb 22, 2023
@casavaca
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Feb 22, 2023
@casavaca
feat: Port Topology.Algebra.Order.Group (#2426)
af82934 
Rename only.
@bors
Copy link

bors bot commented Feb 22, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: Port Topology.Algebra.Order.Group [Merged by Bors] - feat: Port Topology.Algebra.Order.Group Feb 22, 2023
@bors bors bot closed this Feb 22, 2023
@bors bors bot deleted the port/Topology.Algebra.Order.Group branch February 22, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dupuisf dupuisf dupuisf left review comments

Assignees
No one assigned
Labels
delegated easy < 20s of review time. See the lifecycle page for guidelines. mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@casavaca @dupuisf @semorrison