Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port LinearAlgebra.LinearIndependent #2436

Closed
wants to merge 18 commits into from
Closed

[Merged by Bors] - feat: port LinearAlgebra.LinearIndependent #2436

wants to merge 18 commits into from

Conversation

jcommelin
Copy link
Member

Open in Gitpod

@jcommelin
feat: port LinearAlgebra.LinearIndependent
1af3a1f
@jcommelin
Initial file copy from mathport
3b6e180
@jcommelin
automated fixes
8612692 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@jcommelin jcommelin added the mathlib-port This is a port of a theory file from mathlib. label Feb 22, 2023
@jcommelin jcommelin added the help-wanted The author needs attention to resolve issues label Feb 22, 2023
@Komyyy
Copy link
Collaborator

Komyyy commented Feb 23, 2023

Discussion about naming convention:
https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Naming.20convention

@Komyyy Komyyy added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues labels Feb 23, 2023
jcommelin
jcommelin commented Feb 23, 2023
View reviewed changes
Copy link
Member Author

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 23, 2023
bors bot pushed a commit that referenced this pull request Feb 23, 2023
@jcommelin @Komyyy
feat: port LinearAlgebra.LinearIndependent (#2436)
db8c8ed 
Co-authored-by: Komyyy <pol_tta@outlook.jp>
@bors
Copy link

bors bot commented Feb 23, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port LinearAlgebra.LinearIndependent [Merged by Bors] - feat: port LinearAlgebra.LinearIndependent Feb 23, 2023
@bors bors bot closed this Feb 23, 2023
@bors bors bot deleted the port/LinearAlgebra.LinearIndependent branch February 23, 2023 12:52
mo271 pushed a commit that referenced this pull request Feb 24, 2023
@jcommelin @Komyyy @mo271
feat: port LinearAlgebra.LinearIndependent (#2436)
41f6ba5 
Co-authored-by: Komyyy <pol_tta@outlook.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcommelin @Komyyy @semorrison