Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port CategoryTheory.IsConnected #2443

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat: port CategoryTheory.IsConnected #2443

wants to merge 9 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented Feb 22, 2023

Open in Gitpod

@mo271
feat: port CategoryTheory.IsConnected
9947e69
@mo271
Initial file copy from mathport
d449e08
@mo271
automated fixes
a8ae0e4 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@mo271
first pass
ed4c53f
@mo271 mo271 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Feb 22, 2023
@mo271 mo271 added help-wanted The author needs attention to resolve issues and removed WIP Work in progress labels Feb 22, 2023
@mo271
Copy link
Collaborator Author

mo271 commented Feb 24, 2023

TODO:

  • IsConnected.of_any_functor_const_on_obj: "failed to synthesize instance"
    Subsingleton
  • induct_on_objects: "no goals to be solved" but deleting the last two lines of the proof gives "don't know how to synthesize placeholder"
  • IsConnected.of_induct: simp not as stong as in mathlib3
  • isPreconnected_op: "failed to synthesize instance Subsingleton ..."
  • 'zigzag_equivalence':
type mismatch
  zigzag_symmetric
has type
  Symmetric Zigzag : Prop
but is expected to have type
  Zigzag x✝ y✝ → Zigzag y✝ x✝ : Prop
the following variables have been introduced by the implicit lambda feature
  x✝ : J
  y✝ : J

@mattrobball
Copy link
Collaborator

It looks like merging a recent master fixed a few of these. The rest are cleared now.

@mattrobball mattrobball added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues labels Mar 11, 2023
jcommelin
jcommelin approved these changes Mar 11, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 11, 2023
bors bot pushed a commit that referenced this pull request Mar 11, 2023
@mo271 @mattrobball
feat: port CategoryTheory.IsConnected (#2443)
2207652 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: Matthew Ballard <matt@mrb.email>
@bors
Copy link

bors bot commented Mar 11, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port CategoryTheory.IsConnected [Merged by Bors] - feat: port CategoryTheory.IsConnected Mar 11, 2023
@bors bors bot closed this Mar 11, 2023
@bors bors bot deleted the port/CategoryTheory.IsConnected branch March 11, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mo271 @mattrobball @jcommelin @semorrison