Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: Port SetTheory.Cardinal.Divisibility #2473

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat: Port SetTheory.Cardinal.Divisibility #2473

wants to merge 6 commits into from

Conversation

casavaca
Copy link
Collaborator

Open in Gitpod

@casavaca
feat: port SetTheory.Cardinal.Divisibility
74be234
@casavaca
Initial file copy from mathport
a991029
@casavaca
automated fixes
cbf272c 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@casavaca
First pass
e651a71
@casavaca
Update comments
7234fff
@casavaca casavaca added the mathlib-port This is a port of a theory file from mathlib. label Feb 24, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 24, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 24, 2023
@casavaca casavaca added the awaiting-review The author would like community review of the PR label Feb 24, 2023
jcommelin
jcommelin approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 24, 2023
bors bot pushed a commit that referenced this pull request Feb 24, 2023
@casavaca @mo271
feat: Port SetTheory.Cardinal.Divisibility (#2473)
6cd6039 
Co-authored-by: Moritz Firsching <firsching@google.com>
@bors
Copy link

bors bot commented Feb 24, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: Port SetTheory.Cardinal.Divisibility [Merged by Bors] - feat: Port SetTheory.Cardinal.Divisibility Feb 24, 2023
@bors bors bot closed this Feb 24, 2023
@bors bors bot deleted the port/SetTheory.Cardinal.Divisibility branch February 24, 2023 11:36
mo271 added a commit that referenced this pull request Feb 24, 2023
@casavaca @mo271
feat: Port SetTheory.Cardinal.Divisibility (#2473)
5b1ea16 
Co-authored-by: Moritz Firsching <firsching@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@casavaca @jcommelin @semorrison @mo271