Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: Port Combinatorics.SimpleGraph.StronglyRegular #2476

Closed

Conversation

casavaca
Copy link
Collaborator

@casavaca casavaca commented Feb 24, 2023


Help wanted: One error left: This simp doesn't work. It's weird because if you guide lean, rw doesn't work, even if it looks the same. I guess it has something to do with Quot.liftOn which hide behind dsimp [Finset.card, Multiset.card]?

theorem h : card (Set.toFinset (neighborSet G v ∩ neighborSet G w)) = k := sorry
example : Fintype.card (G.commonNeighbors v w) = k := by
  rw [←Set.toFinset_card]
  unfold commonNeighbors
  have hh := @h V _ G _ k v w
  rw [←hh] --- Here 1
  congr    --- Here 2
  simp [Set.fintypeInterOfRight]

at Here 1: look the same but it's not.

⊢ card (Set.toFinset (neighborSet G v ∩ neighborSet G w)) =
  card (Set.toFinset (neighborSet G v ∩ neighborSet G w))

at Here 2:

⊢ (Subtype.fintype fun x => x ∈ neighborSet G v ∩ neighborSet G w) =
    Set.fintypeInterOfRight (neighborSet G v) (neighborSet G w)

Open in Gitpod

@casavaca casavaca added help-wanted The author needs attention to resolve issues mathlib-port This is a port of a theory file from mathlib. labels Feb 24, 2023
@semorrison semorrison added blocked-by-other-PR This PR depends on another PR which is still in the queue. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. labels Feb 24, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@casavaca casavaca force-pushed the port/Combinatorics.SimpleGraph.StronglyRegular branch from 7f8c121 to 0a76ea3 Compare February 24, 2023 19:06
@kmill
Copy link
Contributor

kmill commented Feb 25, 2023

@casavaca It basically comes down to how in Lean 3 there's a feature where typeclass arguments can be solved for using unification as a fallback, and we designed a number of lemmas with this feature in mind. One workaround is to use @ and (_) arguments (I've left a porting note).

@kmill kmill added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues labels Feb 25, 2023
…lib4 into port/Combinatorics.SimpleGraph.StronglyRegular
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 27, 2023
@ChrisHughes24
Copy link
Member

bors r+

@bors
Copy link

bors bot commented Feb 27, 2023

👎 Rejected by label

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 27, 2023
@ChrisHughes24 ChrisHughes24 removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 27, 2023
@ChrisHughes24
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Feb 27, 2023
Co-authored-by: Kyle Miller <kmill31415@gmail.com>
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
@bors
Copy link

bors bot commented Feb 27, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: Port Combinatorics.SimpleGraph.StronglyRegular [Merged by Bors] - feat: Port Combinatorics.SimpleGraph.StronglyRegular Feb 27, 2023
@bors bors bot closed this Feb 27, 2023
@bors bors bot deleted the port/Combinatorics.SimpleGraph.StronglyRegular branch February 27, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants