New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: Port Combinatorics.SimpleGraph.StronglyRegular #2476
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casavaca
added
help-wanted
The author needs attention to resolve issues
mathlib-port
This is a port of a theory file from mathlib.
labels
Feb 24, 2023
semorrison
added
blocked-by-other-PR
This PR depends on another PR which is still in the queue.
and removed
blocked-by-other-PR
This PR depends on another PR which is still in the queue.
labels
Feb 24, 2023
This PR/issue depends on:
|
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
casavaca
force-pushed
the
port/Combinatorics.SimpleGraph.StronglyRegular
branch
from
February 24, 2023 19:06
7f8c121
to
0a76ea3
Compare
@casavaca It basically comes down to how in Lean 3 there's a feature where typeclass arguments can be solved for using unification as a fallback, and we designed a number of lemmas with this feature in mind. One workaround is to use |
kmill
added
awaiting-review
The author would like community review of the PR
and removed
help-wanted
The author needs attention to resolve issues
labels
Feb 25, 2023
…lib4 into port/Combinatorics.SimpleGraph.StronglyRegular
semorrison
added
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging.
label
Feb 27, 2023
…SimpleGraph.StronglyRegular
bors r+ |
👎 Rejected by label |
github-actions
bot
added
ready-to-merge
This PR has been sent to bors.
and removed
awaiting-review
The author would like community review of the PR
labels
Feb 27, 2023
ChrisHughes24
removed
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging.
label
Feb 27, 2023
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 27, 2023
Co-authored-by: Kyle Miller <kmill31415@gmail.com> Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
feat: Port Combinatorics.SimpleGraph.StronglyRegular
[Merged by Bors] - feat: Port Combinatorics.SimpleGraph.StronglyRegular
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
mathlib-port
This is a port of a theory file from mathlib.
ready-to-merge
This PR has been sent to bors.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combinatorics.SimpleGraph.Basic
#1883Help wanted: One error left: This
simp
doesn't work. It's weird because if you guide lean,rw
doesn't work, even if it looks the same. I guess it has something to do withQuot.liftOn
which hide behinddsimp [Finset.card, Multiset.card]
?at Here 1: look the same but it's not.
at Here 2: