Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - bump: update Aesop to 2022-02-24 #2484

Closed
wants to merge 11 commits into from

Conversation

JLimperg
Copy link
Collaborator

@JLimperg JLimperg commented Feb 24, 2023

This version of Aesop supports local and scoped rules.


I'm really confused about the changes in Tactic.Positivity.Core and Tactic.Ring.Basic. Without these changes, the files don't compile locally. But these files have nothing to do with Aesop and I didn't change anything else afaict. (Edit: the MfldSetTac test also needs these weird changes.)

Open in Gitpod

@gebner
Copy link
Member

gebner commented Feb 28, 2023

But these files have nothing to do with Aesop and I didn't change anything else afaict.

The errors go away after changing import Aesop to import Aesop.Main. Apparently the test files pollute the environment (but I'm not sure yet how). leanprover-community/aesop#48

@gebner
Copy link
Member

gebner commented Feb 28, 2023

Apparently the test files pollute the environment (but I'm not sure yet how).

In the most basic way possible!

inductive A : Prop where
| intro

No wonder A no longer works as an auto-implicit afterwards..

@gebner gebner added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Feb 28, 2023
@JLimperg
Copy link
Collaborator Author

JLimperg commented Mar 1, 2023

Good lord I'm an idiot. Thanks for debugging this.

@JLimperg
Copy link
Collaborator Author

JLimperg commented Mar 1, 2023

Fixed now.

@JLimperg JLimperg added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Mar 1, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 1, 2023
@gebner
Copy link
Member

gebner commented Mar 1, 2023

bors d+

@bors
Copy link

bors bot commented Mar 1, 2023

✌️ JLimperg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 1, 2023
@JLimperg
Copy link
Collaborator Author

JLimperg commented Mar 1, 2023

bors r+

bors bot pushed a commit that referenced this pull request Mar 1, 2023
This version of Aesop supports local and scoped rules.
@bors
Copy link

bors bot commented Mar 1, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title bump: update Aesop to 2022-02-24 [Merged by Bors] - bump: update Aesop to 2022-02-24 Mar 1, 2023
@bors bors bot closed this Mar 1, 2023
@bors bors bot deleted the bump-aesop-2023-02-24 branch March 1, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants