Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Combinatorics.SimpleGraph.Subgraph #2495

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat: port Combinatorics.SimpleGraph.Subgraph #2495

wants to merge 9 commits into from

Conversation

int-y1
Copy link
Collaborator

@int-y1 int-y1 commented Feb 25, 2023

Open in Gitpod

@int-y1
feat: port Combinatorics.SimpleGraph.Subgraph
5710a07
@int-y1
Initial file copy from mathport
f0d56f8
@int-y1
automated fixes
5357222 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@int-y1
first pass
631ec3d
@int-y1 int-y1 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Feb 25, 2023
@int-y1 int-y1 force-pushed the port/Combinatorics.SimpleGraph.Subgraph branch from 5179c99 to 638c816 Compare February 25, 2023 11:43
@int-y1
Copy link
Collaborator Author

int-y1 commented Feb 25, 2023 •
edited

Remaining task:

  • Fix error with congr in degree_spanningCoe

@int-y1 int-y1 added help-wanted The author needs attention to resolve issues and removed WIP Work in progress labels Feb 25, 2023
@int-y1 int-y1 removed the help-wanted The author needs attention to resolve issues label Feb 25, 2023
@kmill
Copy link
Contributor

kmill commented Feb 25, 2023 •
edited

@int-y1 I put in a different resolution to the congr proof problem (I started looking at the file right after you added "help wanted"). I think the "right" way to deal with this is apply Subsingleton.elim. This is something congr used to do itself.

@kmill kmill added the awaiting-review The author would like community review of the PR label Feb 25, 2023
@ChrisHughes24
Copy link
Member

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 27, 2023
bors bot pushed a commit that referenced this pull request Feb 27, 2023
@int-y1 @kmill
feat: port Combinatorics.SimpleGraph.Subgraph (#2495)
e869094 
Co-authored-by: Kyle Miller <kmill31415@gmail.com>
@bors
Copy link

bors bot commented Feb 27, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Combinatorics.SimpleGraph.Subgraph [Merged by Bors] - feat: port Combinatorics.SimpleGraph.Subgraph Feb 27, 2023
@bors bors bot closed this Feb 27, 2023
@bors bors bot deleted the port/Combinatorics.SimpleGraph.Subgraph branch February 27, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@int-y1 @kmill @ChrisHughes24