Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: Simple graphs form a complete boolean algebra #2502

Closed
wants to merge 7 commits into from

Conversation

@YaelDillies YaelDillies added the mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged label Feb 26, 2023
@eric-wieser eric-wieser added the awaiting-author A reviewer has asked the author a question or requested changes label Mar 21, 2023
@YaelDillies YaelDillies force-pushed the simple_graph_complete_boolean_algebra branch from 4aa0f2f to dcba322 Compare March 23, 2023 16:49
@YaelDillies YaelDillies added help-wanted The author needs attention to resolve issues and removed awaiting-author A reviewer has asked the author a question or requested changes labels Mar 24, 2023
@YaelDillies
Copy link
Collaborator Author

YaelDillies commented Mar 24, 2023

I just spent two hours trying to fix the errors, but VScode isn't cooperating. If you try fixing it, know that everything broke because ∃ G ∈ s, p G now means ∃ G, G ∈ s ∧ p G instead of ∃ G, ∃ _ : G ∈ s, p G.

@kmill
Copy link
Contributor

kmill commented Mar 27, 2023

I went through leanprover-community/mathlib#18285 line by line to check that this PR is making all the same changes, and I also fixed the rest of the errors.

I did cheat with some of the proofs and rewrote them using simp or simpa when things got too tricky. @YaelDillies These are in the CompleteBooleanAlgebra and CompleteDistribLattice instances, if you want to try to recover something like the original proofs (I figured having some working proof would be helpful for getting to a state you're happy with).

@YaelDillies
Copy link
Collaborator Author

I went through your changes and I'm very happy with your new proofs! 🙏

@YaelDillies YaelDillies added awaiting-review and removed help-wanted The author needs attention to resolve issues labels Mar 27, 2023
@semorrison
Copy link
Contributor

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Mar 27, 2023
bors bot pushed a commit that referenced this pull request Mar 27, 2023
Match leanprover-community/mathlib#18285

* [`combinatorics.simple_graph.basic`@`db53863fb135228820ee0b08e8dce9349a3d911b`..`c6ef6387ede9983aee397d442974e61f89dfd87b`](https://leanprover-community.github.io/mathlib-port-status/file/combinatorics/simple_graph/basic?range=db53863fb135228820ee0b08e8dce9349a3d911b..c6ef6387ede9983aee397d442974e61f89dfd87b)
* [`combinatorics.simple_graph.subgraph`@`d6e84a0d3db8910c99b3aa0c56be88fa8bab6f80`..`c6ef6387ede9983aee397d442974e61f89dfd87b`](https://leanprover-community.github.io/mathlib-port-status/file/combinatorics/simple_graph/subgraph?range=d6e84a0d3db8910c99b3aa0c56be88fa8bab6f80..c6ef6387ede9983aee397d442974e61f89dfd87b)



Co-authored-by: Kyle Miller <kmill31415@gmail.com>
@bors
Copy link

bors bot commented Mar 27, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: Simple graphs form a complete boolean algebra [Merged by Bors] - feat: Simple graphs form a complete boolean algebra Mar 27, 2023
@bors bors bot closed this Mar 27, 2023
@bors bors bot deleted the simple_graph_complete_boolean_algebra branch March 27, 2023 21:20
joelriou pushed a commit that referenced this pull request Mar 30, 2023
Match leanprover-community/mathlib#18285

* [`combinatorics.simple_graph.basic`@`db53863fb135228820ee0b08e8dce9349a3d911b`..`c6ef6387ede9983aee397d442974e61f89dfd87b`](https://leanprover-community.github.io/mathlib-port-status/file/combinatorics/simple_graph/basic?range=db53863fb135228820ee0b08e8dce9349a3d911b..c6ef6387ede9983aee397d442974e61f89dfd87b)
* [`combinatorics.simple_graph.subgraph`@`d6e84a0d3db8910c99b3aa0c56be88fa8bab6f80`..`c6ef6387ede9983aee397d442974e61f89dfd87b`](https://leanprover-community.github.io/mathlib-port-status/file/combinatorics/simple_graph/subgraph?range=d6e84a0d3db8910c99b3aa0c56be88fa8bab6f80..c6ef6387ede9983aee397d442974e61f89dfd87b)



Co-authored-by: Kyle Miller <kmill31415@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors.
Projects
No open projects
Status: Awaiting mathport output
Development

Successfully merging this pull request may close these issues.

None yet

4 participants