Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Topology.Algebra.Order.UpperLower #2503

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat: port Topology.Algebra.Order.UpperLower #2503

wants to merge 5 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented Feb 26, 2023 •
edited by github-actions bot

@mo271
feat: port Topology.Algebra.Order.UpperLower
88abdc7
@mo271
Initial file copy from mathport
9b367b2
@mo271
automated fixes
3e29cc8 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@mo271
first pass
95ea007
@mo271 mo271 added the mathlib-port This is a port of a theory file from mathlib. label Feb 26, 2023
@mo271
Copy link
Collaborator Author

mo271 commented Feb 26, 2023

comm_semigroup.is_central_scalar recently changed (got to_additive) and apparently group_theory/group_action/opposite needs some syncing or something...

@mo271 mo271 added the WIP Work in progress label Feb 26, 2023
@mo271
Copy link
Collaborator Author

mo271 commented Feb 26, 2023

already in progress, I see: #2344

@mo271 mo271 added blocked-by-other-PR This PR depends on another PR which is still in the queue. and removed WIP Work in progress labels Feb 26, 2023
@semorrison semorrison added blocked-by-other-PR This PR depends on another PR which is still in the queue. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. labels Feb 26, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 1, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 2, 2023
@mo271 mo271 added the awaiting-review The author would like community review of the PR label Mar 2, 2023
jcommelin
jcommelin approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 2, 2023
bors bot pushed a commit that referenced this pull request Mar 2, 2023
@mo271
feat: port Topology.Algebra.Order.UpperLower (#2503)
4f884ff 
- [x] depends on: #2344



Co-authored-by: Moritz Firsching <firsching@google.com>
@bors
Copy link

bors bot commented Mar 2, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Topology.Algebra.Order.UpperLower [Merged by Bors] - feat: port Topology.Algebra.Order.UpperLower Mar 2, 2023
@bors bors bot closed this Mar 2, 2023
@bors bors bot deleted the port/Topology.Algebra.Order.UpperLower branch March 2, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mo271 @semorrison @jcommelin