New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: a canonically ordered semiring is an ordered monoid #2510
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semorrison
added
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging.
label
Feb 27, 2023
urkud
added
awaiting-review
The author would like community review of the PR
mathlib3-pair
This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged
and removed
merge-conflict
The PR has a merge conflict with master, and needs manual merging.
labels
Feb 27, 2023
bors bot
pushed a commit
to leanprover-community/mathlib
that referenced
this pull request
Feb 27, 2023
…iring.to_ordered_comm_monoid` (#18504) Also merge `finset.prod_le_prod'` with `finset.prod_le_prod''`. Mathlib 4 version is leanprover-community/mathlib4#2510
jcommelin
approved these changes
Feb 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
semorrison
added
ready-to-merge
This PR has been sent to bors.
and removed
awaiting-review
The author would like community review of the PR
labels
Feb 28, 2023
bors bot
pushed a commit
that referenced
this pull request
Feb 28, 2023
Mathlib 3 version is leanprover-community/mathlib#18504 * [`algebra.big_operators.order`@`afdb4fa3b32d41106a4a09b371ce549ad7958abd`..`824f9ae93a4f5174d2ea948e2d75843dd83447bb`](https://leanprover-community.github.io/mathlib-port-status/file/algebra/big_operators/order?range=afdb4fa3b32d41106a4a09b371ce549ad7958abd..824f9ae93a4f5174d2ea948e2d75843dd83447bb) * [`algebra.order.ring.canonical`@`a1b3559280c8e09220759127b400d1b02d7ac071`..`824f9ae93a4f5174d2ea948e2d75843dd83447bb`](https://leanprover-community.github.io/mathlib-port-status/file/algebra/order/ring/canonical?range=a1b3559280c8e09220759127b400d1b02d7ac071..824f9ae93a4f5174d2ea948e2d75843dd83447bb)
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
feat: a canonically ordered semiring is an ordered monoid
[Merged by Bors] - feat: a canonically ordered semiring is an ordered monoid
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
mathlib3-pair
This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged
ready-to-merge
This PR has been sent to bors.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mathlib 3 version is leanprover-community/mathlib#18504
algebra.big_operators.order
@afdb4fa3b32d41106a4a09b371ce549ad7958abd
..824f9ae93a4f5174d2ea948e2d75843dd83447bb
algebra.order.ring.canonical
@a1b3559280c8e09220759127b400d1b02d7ac071
..824f9ae93a4f5174d2ea948e2d75843dd83447bb