Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port MeasureTheory.CardMeasurableSpace #2516

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat: port MeasureTheory.CardMeasurableSpace #2516

wants to merge 6 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented Feb 27, 2023

Open in Gitpod

@mo271 mo271 added help-wanted The author needs attention to resolve issues WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Feb 27, 2023
@mo271 mo271 removed the WIP Work in progress label Mar 8, 2023
@urkud urkud force-pushed the port/MeasureTheory.CardMeasurableSpace branch from 5c1b642 to cbf1724 Compare March 16, 2023 05:29
@urkud urkud added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues labels Mar 16, 2023
@urkud
Copy link
Member

urkud commented Mar 16, 2023

@mo271 I fixed compile errors. I don't know why instances were unable to see through your local notation. I unfolded all dot notation and removed universe specification (moved to the next definition) to make it work with quotPrecheck.

Generally, adding variables for instances Lean fails to find can't help because you added some arbitrary Preorder on ω₁, not the well-founded linear order.

@ChrisHughes24
Copy link
Member

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 17, 2023
bors bot pushed a commit that referenced this pull request Mar 17, 2023
@mo271 @urkud
feat: port MeasureTheory.CardMeasurableSpace (#2516)
6d2275b 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
@bors
Copy link

bors bot commented Mar 17, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port MeasureTheory.CardMeasurableSpace [Merged by Bors] - feat: port MeasureTheory.CardMeasurableSpace Mar 17, 2023
@bors bors bot closed this Mar 17, 2023
@bors bors bot deleted the port/MeasureTheory.CardMeasurableSpace branch March 17, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mo271 @urkud @ChrisHughes24