[Merged by Bors] - feat: forward-port leanprover-community/mathlib#18449 #2518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
the
mathlib3-pair
1 task
bors bot
pushed a commit
to leanprover-community/mathlib
that referenced
this pull request
Feb 28, 2023
This typeclass is reasonably new, so some obvious instances are missing. Also adds some basic API lemmas that were missing about the casting functions `set.up` and `set_semiring.down`. forward-ported as leanprover-community/mathlib4#2518
bors bot
pushed a commit
to leanprover-community/mathlib
that referenced
this pull request
Feb 28, 2023
This typeclass is reasonably new, so some obvious instances are missing. Also adds some basic API lemmas that were missing about the casting functions `set.up` and `set_semiring.down`. forward-ported as leanprover-community/mathlib4#2518
2 tasks
bors bot
pushed a commit
that referenced
this pull request
Mar 2, 2023
The diff being ported is leanprover-community/mathlib3port@d034837#diff-968496f13ddf1f2e9b559f374e46c52125a2ada4f449bbce0989bc8ef4965e67. This also includes a fix from leanprover-community/mathlib#18539
|
bors r- |
|
This isn't ready to go yet, it's waiting for the SHA from mathlib3! (which is why it doesn't have |
|
Canceled. |
eric-wieser
commented
Mar 2, 2023
bors bot
pushed a commit
to leanprover-community/mathlib
that referenced
this pull request
Mar 2, 2023
#18539) Previously this was abusing the defeq of the types, resulting in lemmas stated in weird ways. This also fixes a type in #18449, and adds three missing lemmas about `image_hom`. Forward port of `set_semiring` will be included in leanprover-community/mathlib4#2518
eric-wieser
added
awaiting-author
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Mar 2, 2023
The diff being ported is leanprover-community/mathlib3port@d034837#diff-968496f13ddf1f2e9b559f374e46c52125a2ada4f449bbce0989bc8ef4965e67. This also includes a fix from leanprover-community/mathlib#18539
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
bors bot
pushed a commit
that referenced
this pull request
Mar 16, 2023
This records leanprover-community/mathlib#18539 as already forward-ported; the actual typo fix was included in #2518.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff being ported is leanprover-community/mathlib3port@d034837#diff-968496f13ddf1f2e9b559f374e46c52125a2ada4f449bbce0989bc8ef4965e67.
This also includes a fix from leanprover-community/mathlib#18539