Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: Port Algebra.Module.Submodule.Bilinear #2531

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat: Port Algebra.Module.Submodule.Bilinear #2531

wants to merge 4 commits into from

Conversation

casavaca
Copy link
Collaborator

@casavaca casavaca commented Feb 28, 2023 •
edited by github-actions bot

@casavaca casavaca added blocked-by-other-PR This PR depends on another PR which is still in the queue. mathlib-port This is a port of a theory file from mathlib. labels Feb 28, 2023
@semorrison semorrison removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Feb 28, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@casavaca
feat: port Algebra.Module.Submodule.Bilinear
a324d64
@casavaca
Initial file copy from mathport
20dd0b5
@casavaca
automated fixes
5a58cee 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@casavaca
Fixes
7f0faed
@casavaca casavaca force-pushed the port/Algebra.Module.Submodule.Bilinear branch from 31fbf45 to 7f0faed Compare February 28, 2023 07:35
@casavaca casavaca added the awaiting-review The author would like community review of the PR label Feb 28, 2023
jcommelin
jcommelin approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 28, 2023
bors bot pushed a commit that referenced this pull request Feb 28, 2023
@casavaca
feat: Port Algebra.Module.Submodule.Bilinear (#2531)
cd44151
@bors
Copy link

bors bot commented Feb 28, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: Port Algebra.Module.Submodule.Bilinear [Merged by Bors] - feat: Port Algebra.Module.Submodule.Bilinear Feb 28, 2023
@bors bors bot closed this Feb 28, 2023
@bors bors bot deleted the port/Algebra.Module.Submodule.Bilinear branch February 28, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@casavaca @semorrison @jcommelin