Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port CategoryTheory.Limits.Shapes.Products #2564

Closed
wants to merge 12 commits into from
Closed

[Merged by Bors] - feat: port CategoryTheory.Limits.Shapes.Products #2564

wants to merge 12 commits into from

Conversation

joelriou
Copy link
Collaborator

@joelriou joelriou commented Mar 1, 2023

Open in Gitpod

@joelriou
feat: port CategoryTheory.Limits.Shapes.Products
d482fe9
@joelriou
Initial file copy from mathport
dd61b57
@joelriou
automated fixes
b3b7993 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@joelriou joelriou added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Mar 1, 2023
@joelriou joelriou added awaiting-CI awaiting-review The author would like community review of the PR and removed WIP Work in progress awaiting-CI labels Mar 2, 2023
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 2, 2023
@bors
Copy link

bors bot commented Mar 2, 2023

Merge conflict.

@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 2, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 2, 2023
@mattrobball mattrobball mentioned this pull request Mar 4, 2023
Closed
3 tasks
@mattrobball mattrobball mentioned this pull request Mar 5, 2023
Closed
1 task
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 6, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 6, 2023
@mattrobball mattrobball mentioned this pull request Mar 7, 2023
Closed
2 tasks
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 7, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 7, 2023
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

bors bot pushed a commit that referenced this pull request Mar 7, 2023
@joelriou @jcommelin
feat: port CategoryTheory.Limits.Shapes.Products (#2564)
4037792 
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Mar 7, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port CategoryTheory.Limits.Shapes.Products [Merged by Bors] - feat: port CategoryTheory.Limits.Shapes.Products Mar 7, 2023
@bors bors bot closed this Mar 7, 2023
@bors bors bot deleted the port/CategoryTheory.Limits.Shapes.Products branch March 7, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joelriou @jcommelin @semorrison