Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: propagate_tags tactic #258

Closed
wants to merge 7 commits into from
Closed

feat: propagate_tags tactic #258

wants to merge 7 commits into from

Conversation

Beanway144
Copy link
Contributor

Adds propagate_tags

@semorrison semorrison added awaiting-review awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Jul 27, 2022
@semorrison
Copy link
Contributor

@Beanway144, sorry this languished on the PR queue for a while. Would you be able to merge the conflict and adopt Mario's suggestions?

Beanway144 and others added 4 commits July 27, 2022 14:21
@Beanway144 @digama0
Update Mathlib/Tactic/PropagateTags.lean
93f2cd7 
Change `guard_tags` to `guard_tag`

Co-authored-by: Mario Carneiro <di.gama@gmail.com>
@Beanway144 @digama0
Update Mathlib/Tactic/PropagateTags.lean
be2d48b 
Formatting

Co-authored-by: Mario Carneiro <di.gama@gmail.com>
@Beanway144
Merge branch 'master' into propagate-tags
6391cb3
@Beanway144
Update PropagateTags.lean
e781fb7 
Change `guard_tags` to `guard_tag` in tests
@semorrison semorrison mentioned this pull request Sep 20, 2022
Open
@semorrison semorrison added WIP Work in progress please-adopt awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-author A reviewer has asked the author a question or requested changes please-adopt labels Oct 8, 2022
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Nov 24, 2022
@semorrison semorrison added the t-meta Tactics, attributes or user commands label Aug 6, 2023
@bors bors bot changed the base branch from master to ScottCarnahan/BinomialRing2 September 17, 2023 03:23
@semorrison semorrison changed the base branch from ScottCarnahan/BinomialRing2 to master September 17, 2023 12:19
@jcommelin
Copy link
Member

This pull request has not seen any activity for quite a while, and it does not pass all CI checks. For these reasons, I am closing it now.

If you are still interested in getting this PR merged, please re-open the PR, update the branch, and make sure that all CI checks pass, Please label the PR with awaiting-review when ready.

@jcommelin jcommelin closed this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digama0 digama0 digama0 left review comments

Assignees
No one assigned
Labels
awaiting-author A reviewer has asked the author a question or requested changes merge-conflict The PR has a merge conflict with master, and needs manual merging. t-meta Tactics, attributes or user commands WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Beanway144 @semorrison @jcommelin @digama0