Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port CategoryTheory.Adjunction.Comma #2591

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat: port CategoryTheory.Adjunction.Comma #2591

wants to merge 7 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented Mar 3, 2023

Open in Gitpod

@mo271
feat: port CategoryTheory.Adjunction.Comma
b073434
@mo271
Initial file copy from mathport
052c775
@mo271
automated fixes
85853dc 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@mo271
first pass
c74ac47
@mo271 mo271 added the mathlib-port This is a port of a theory file from mathlib. label Mar 3, 2023
@mo271
Copy link
Collaborator Author

mo271 commented Mar 3, 2023 •
edited

Currently two proofs are not yet working:

  • mkInitialOfLeftAdjoint and the dual
  • mkTerminalOfRightAdjoint
    Unsure if tactic.discrete_case is needed for this?!

@mo271 mo271 added the help-wanted The author needs attention to resolve issues label Mar 3, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 7, 2023
@adamtopaz
Copy link
Contributor

Currently two proofs are not yet working:

* [ ]  `mkInitialOfLeftAdjoint` and the dual

* [ ]  `mkTerminalOfRightAdjoint`
  Unsure if `tactic.discrete_case` is needed for this?!

These are both done now. If you're happy with the rest of the file, then please add the awaiting-review label.

@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 10, 2023
@adamtopaz adamtopaz mentioned this pull request Mar 10, 2023
Closed
1 task
@mo271 mo271 added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues labels Mar 10, 2023
jcommelin
jcommelin approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 10, 2023
bors bot pushed a commit that referenced this pull request Mar 10, 2023
@mo271 @adamtopaz
feat: port CategoryTheory.Adjunction.Comma (#2591)
7a06df4 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: adamtopaz <github@adamtopaz.com>
@bors
Copy link

bors bot commented Mar 10, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port CategoryTheory.Adjunction.Comma [Merged by Bors] - feat: port CategoryTheory.Adjunction.Comma Mar 10, 2023
@bors bors bot closed this Mar 10, 2023
@bors bors bot deleted the port/CategoryTheory.Adjunction.Comma branch March 10, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mo271 @adamtopaz @jcommelin @semorrison