Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Algebra.DirectSum.Module #2596

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat: port Algebra.DirectSum.Module #2596

wants to merge 9 commits into from

Conversation

int-y1
Copy link
Collaborator

@int-y1 int-y1 commented Mar 3, 2023

Open in Gitpod

@int-y1
feat: port Algebra.DirectSum.Module
421368f
@int-y1
Initial file copy from mathport
e917210
@int-y1
automated fixes
a963e6b 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@int-y1 int-y1 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Mar 3, 2023
@int-y1 int-y1 force-pushed the port/Algebra.DirectSum.Module branch from 1a87c5b to 567d77d Compare March 3, 2023 10:53
@int-y1
Copy link
Collaborator Author

int-y1 commented Mar 3, 2023 •
edited by Parcly-Taxel

2 remaining errors.

  • coeLinearMap_of
  • IsInternal.collectedBasis_coe

@int-y1 int-y1 added the help-wanted The author needs attention to resolve issues label Mar 3, 2023
@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues WIP Work in progress labels Mar 15, 2023
@Ruben-VandeVelde
Copy link
Collaborator

I pushed some pretty cursed fixes, but it looks like this builds now

@ChrisHughes24
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 17, 2023
bors bot pushed a commit that referenced this pull request Mar 17, 2023
@int-y1 @Ruben-VandeVelde
feat: port Algebra.DirectSum.Module (#2596)
a781fc8 
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@bors
Copy link

bors bot commented Mar 17, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Algebra.DirectSum.Module [Merged by Bors] - feat: port Algebra.DirectSum.Module Mar 17, 2023
@bors bors bot closed this Mar 17, 2023
@bors bors bot deleted the port/Algebra.DirectSum.Module branch March 17, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@int-y1 @Ruben-VandeVelde @ChrisHughes24 @Parcly-Taxel