Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port CategoryTheory.Limits.Unit #2597

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat: port CategoryTheory.Limits.Unit #2597

wants to merge 4 commits into from

Conversation

joelriou
Copy link
Collaborator

@joelriou joelriou commented Mar 3, 2023

Open in Gitpod

@joelriou
feat: port CategoryTheory.Limits.Unit
8aa3c69
@joelriou
Initial file copy from mathport
baede18
@joelriou
automated fixes
d19cfdf 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@joelriou joelriou added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Mar 3, 2023
@joelriou joelriou added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Mar 3, 2023
jcommelin
jcommelin approved these changes Mar 4, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 4, 2023
bors bot pushed a commit that referenced this pull request Mar 4, 2023
@joelriou
feat: port CategoryTheory.Limits.Unit (#2597)
cd0354b
@bors
Copy link

bors bot commented Mar 4, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port CategoryTheory.Limits.Unit [Merged by Bors] - feat: port CategoryTheory.Limits.Unit Mar 4, 2023
@bors bors bot closed this Mar 4, 2023
@bors bors bot deleted the port/CategoryTheory.Limits.Unit branch March 4, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joelriou @jcommelin @semorrison