Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Polynomial.Coeff #2624

Closed
wants to merge 58 commits into from
Closed

[Merged by Bors] - feat: port Data.Polynomial.Coeff #2624

wants to merge 58 commits into from

Conversation

Komyyy
Copy link
Collaborator

@Komyyy Komyyy commented Mar 4, 2023 •
edited

Komyyy added 30 commits March 3, 2023 09:47
@Komyyy
feat: port Algebra.MonoidAlgebra.Basic
88b9dbc
@Komyyy
Initial file copy from mathport
86f75f9
@Komyyy
automated fixes
adf24d4 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@Komyyy
348 red errors left
f582d4a
@Komyyy
257 red errors left
5cd67ad
@Komyyy
110 red errors left
2a1a863
@Komyyy
91 red errors left
ec483e8
@Komyyy
86 red errors left
53b3996
@Komyyy
33 red errors left
9fd54d2
@Komyyy
no errors anymore
95d1ddd
@Komyyy
no build lints anymore
bee7928
@Komyyy
rename instances
711d926
@Komyyy
Merge branch 'pol_tta/RenameFinsuppInstance' into port/Algebra.Monoid…
124f12a 
…Algebra.Basic
@Komyyy
rename instances
ca6674c
@Komyyy
change simps! attribute
99065fe
@Komyyy
Merge branch 'pol_tta/opAddEquiv_apply' into port/Algebra.MonoidAlgeb…
763aa5d 
…ra.Basic
@Komyyy
remove theorem
d647edf
@Komyyy
rename instance
334628f
@Komyyy
naming convention
028beb8
@Komyyy
simps
178e3cb
@Komyyy
docs
d7aecc3
@Komyyy
Merge branch 'master' into pol_tta/opAddEquiv_apply
f84833a
@Komyyy
Merge branch 'master' into pol_tta/RenameFinsuppInstance
1c53807
@Komyyy
Merge branch 'pol_tta/opAddEquiv_apply' into port/Algebra.MonoidAlgeb…
b3bc006 
…ra.Basic
@Komyyy
Merge branch 'pol_tta/RenameFinsuppInstance' into port/Algebra.Monoid…
b0ab99d 
…Algebra.Basic
@Komyyy
feat: port Data.Polynomial.Basic
4fff7c8
@Komyyy
Initial file copy from mathport
313e883
@Komyyy
automated fixes
63f82ce 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@Komyyy
no errors anymore
4821042
@Komyyy
no lints anymore
ea49d42
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 8, 2023
@Komyyy Komyyy removed blocked-by-other-PR This PR depends on another PR which is still in the queue. merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Mar 8, 2023
jcommelin
jcommelin approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.

bors d+

@bors
Copy link

bors bot commented Mar 8, 2023

✌️ Komyyy can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Mar 8, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@Komyyy Komyyy removed the awaiting-CI label Mar 8, 2023
@Komyyy
Copy link
Collaborator Author

Komyyy commented Mar 8, 2023

bors r+

@bors
Copy link

bors bot commented Mar 8, 2023

Canceled.

@jcommelin
Copy link
Member

bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Mar 8, 2023
@bors
Copy link

bors bot commented Mar 8, 2023

Merge conflict.

@jcommelin
Copy link
Member

bors merge

@bors
Copy link

bors bot commented Mar 8, 2023

Merge conflict.

@Komyyy
Copy link
Collaborator Author

Komyyy commented Mar 8, 2023

bors r+

bors bot pushed a commit that referenced this pull request Mar 8, 2023
@Komyyy
feat: port Data.Polynomial.Coeff (#2624)
d0620ef
@bors
Copy link

bors bot commented Mar 8, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Polynomial.Coeff [Merged by Bors] - feat: port Data.Polynomial.Coeff Mar 8, 2023
@bors bors bot closed this Mar 8, 2023
@bors bors bot deleted the port/Data.Polynomial.Coeff branch March 8, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Komyyy @semorrison @jcommelin