[Merged by Bors] - feat: port Topology.Algebra.Order.Field #2626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkud
force-pushed
the
port/Topology.Algebra.Order.Field
branch
3 times, most recently
from
596e6d5
to
1c027f0
Compare
urkud
added
awaiting-review
urkud
force-pushed
the
port/Topology.Algebra.Order.Field
branch
from
ada1055
to
1a36d9b
Compare
This will still need a forward-port PR to update the sha |
eric-wieser
reviewed
Mar 5, 2023
| @@ -77,6 +77,8 @@ protected def symm (h : α ≃ₜ β) : β ≃ₜ α where | |||
| toEquiv := h.toEquiv.symm | |||
| #align homeomorph.symm Homeomorph.symm | |||
|
|
|||
| @[simp] theorem symm_symm (h : α ≃ₜ β) : h.symm.symm = h := rfl | |||
There was a problem hiding this comment.
This will need an #align once the backport goes through. It might be sensible to add it now so we don't forget.
urkud
commented
Mar 5, 2023
urkud
force-pushed
the
port/Topology.Algebra.Order.Field
branch
from
4ebfa6b
to
799074e
Compare
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
urkud
force-pushed
the
port/Topology.Algebra.Order.Field
branch
from
799074e
to
b37e208
Compare
semorrison
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Mar 6, 2023
I made substantial changes to the proofs. To avoid backporting most of them, in leanprover-community/mathlib#18552 I add `private` to lemmas that are deleted in this PR. Also, I backport `Homeomorph.symm_symm` in leanprover-community/mathlib#18551
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made substantial changes to the proofs. To avoid backporting most of them, in leanprover-community/mathlib#18552 I add
privateto lemmas that are deleted in this PR. Also, I backportHomeomorph.symm_symmin leanprover-community/mathlib#18551