Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Topology.Instances.Rat #2643

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat: port Topology.Instances.Rat #2643

wants to merge 4 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Mar 5, 2023

Open in Gitpod

@urkud urkud force-pushed the port/Topology.Instances.Rat branch 2 times, most recently from 4b190c2 to 8345b24 Compare March 5, 2023 07:53
@urkud
feat: port Topology.Instances.Rat
86d589a
@urkud
Initial file copy from mathport
332b675
@urkud
automated fixes
29332e2 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@urkud
Fix compile
fd560ea
@urkud urkud force-pushed the port/Topology.Instances.Rat branch from 8345b24 to fd560ea Compare March 6, 2023 09:03
@urkud urkud added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. labels Mar 6, 2023
jcommelin
jcommelin approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.

bors d+

@bors
Copy link

bors bot commented Mar 6, 2023

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Mar 6, 2023
@urkud
Copy link
Member Author

urkud commented Mar 6, 2023

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Mar 6, 2023
bors bot pushed a commit that referenced this pull request Mar 6, 2023
@urkud
feat: port Topology.Instances.Rat (#2643)
b55832c
@bors
Copy link

bors bot commented Mar 6, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Topology.Instances.Rat [Merged by Bors] - feat: port Topology.Instances.Rat Mar 6, 2023
@bors bors bot closed this Mar 6, 2023
@bors bors bot deleted the port/Topology.Instances.Rat branch March 6, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
awaiting-CI delegated mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @jcommelin @semorrison