Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Topology.Instances.NNReal #2672

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - feat: port Topology.Instances.NNReal #2672

wants to merge 8 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Mar 5, 2023

Open in Gitpod

@urkud urkud force-pushed the port/Topology.Instances.NNReal branch from c4dfdc9 to e863481 Compare March 5, 2023 23:13
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 6, 2023
@urkud urkud force-pushed the port/Topology.Instances.NNReal branch from 18a298b to 19dd618 Compare March 6, 2023 18:40
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 6, 2023
@urkud urkud added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. labels Mar 6, 2023
jcommelin
jcommelin approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 7, 2023
bors bot pushed a commit that referenced this pull request Mar 7, 2023
@urkud
feat: port Topology.Instances.NNReal (#2672)
c3484b5
@bors
Copy link

bors bot commented Mar 7, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Topology.Instances.NNReal [Merged by Bors] - feat: port Topology.Instances.NNReal Mar 7, 2023
@bors bors bot closed this Mar 7, 2023
@bors bors bot deleted the port/Topology.Instances.NNReal branch March 7, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @jcommelin @semorrison