Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix: ring: use whnfR when obtaining goal #2677

Closed
wants to merge 2 commits into from

Conversation

thorimur
Copy link
Collaborator

@thorimur thorimur commented Mar 6, 2023

Adds whnfR so that goals which are e.g. equalities with metadata are recognized by ring. See zulip.


Open in Gitpod

@thorimur thorimur added awaiting-review The author would like community review of the PR t-meta Tactics, attributes or user commands labels Mar 6, 2023
@digama0
Copy link
Member

digama0 commented Mar 6, 2023

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 6, 2023
bors bot pushed a commit that referenced this pull request Mar 6, 2023
Adds `whnfR` so that goals which are e.g. equalities with metadata are recognized by `ring`. See [zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Bug.20in.20.60ring1.60.3F).
@bors
Copy link

bors bot commented Mar 6, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix: ring: use whnfR when obtaining goal [Merged by Bors] - fix: ring: use whnfR when obtaining goal Mar 6, 2023
@bors bors bot closed this Mar 6, 2023
@bors bors bot deleted the ring-whnfR-on-goal branch March 6, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-meta Tactics, attributes or user commands
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants